LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js - Issue 23528004: [CSS Grid Layout] Update named grid lines syntax to the last version of the specs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js

Issue 23528004: [CSS Grid Layout] Update named grid lines syntax to the last version of the specs (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@named

Patch Set: New parsing based on rune's and jchaffraix's comments Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/css-grid-layout/named-grid-line-get-set.html ('K') | « LayoutTests/fast/css-grid-layout/non-named-grid-line-get-set.html ('k') | LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js

diff --git a/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js b/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js

index 78e7c4816c2d2de15440af92eac8eddeec4a7032..d5151eb1cb57e71dcd473dff82dd8ada84aa835c 100755

--- a/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js

+++ b/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js

@@ -84,8 +84,8 @@ function testInherit()

{

var parentElement = document.createElement("div");

document.body.appendChild(parentElement);

- parentElement.style.gridDefinitionColumns = "50px 'last'";

- parentElement.style.gridDefinitionRows = "'first' 101%";

+ parentElement.style.gridDefinitionColumns = "50px (last)";

+ parentElement.style.gridDefinitionRows = "(first) 101%";

element = document.createElement("div");

parentElement.appendChild(element);

@@ -109,8 +109,8 @@ function testInitial()

element.style.display = "grid";

element.style.width = "300px";

element.style.height = "150px";

- element.style.gridDefinitionColumns = "150% 'last'";

- element.style.gridDefinitionRows = "'first' 1fr";

+ element.style.gridDefinitionColumns = "150% (last)";

+ element.style.gridDefinitionRows = "(first) 1fr";

shouldBe("getComputedStyle(element, '').getPropertyValue('grid-definition-columns')", "'450px last'");

shouldBe("getComputedStyle(element, '').getPropertyValue('grid-definition-rows')", "'first 150px'");