Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: LayoutTests/fast/css-grid-layout/named-grid-line-get-set-expected.txt

Issue 23528004: [CSS Grid Layout] Update named grid lines syntax to the last version of the specs (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@named
Patch Set: New parsing based on rune's and jchaffraix's comments Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/css-grid-layout/named-grid-line-get-set-expected.txt
diff --git a/LayoutTests/fast/css-grid-layout/named-grid-line-get-set-expected.txt b/LayoutTests/fast/css-grid-layout/named-grid-line-get-set-expected.txt
index fdd39c349889c61ff1bc8c23283010541b50d7d9..aae941a6d5f6421caf3d7f95adec4a8cdb1856a0 100644
--- a/LayoutTests/fast/css-grid-layout/named-grid-line-get-set-expected.txt
+++ b/LayoutTests/fast/css-grid-layout/named-grid-line-get-set-expected.txt
@@ -18,6 +18,8 @@ PASS window.getComputedStyle(gridWithFixedMultiple, '').getPropertyValue('grid-d
PASS window.getComputedStyle(gridWithFixedMultiple, '').getPropertyValue('grid-definition-rows') is "first nav 15px last"
PASS window.getComputedStyle(gridWithPercentageSameStringMultipleTimes, '').getPropertyValue('grid-definition-columns') is "first nav 80px nav 120px last"
PASS window.getComputedStyle(gridWithPercentageSameStringMultipleTimes, '').getPropertyValue('grid-definition-rows') is "first nav2 150px nav2 450px last"
+PASS window.getComputedStyle(gridWithRepeatElement, '').getPropertyValue('grid-definition-columns') is "first 10px nav nav2 400px nav nav2 400px"
+PASS window.getComputedStyle(gridWithRepeatElement, '').getPropertyValue('grid-definition-rows') is "100px nav nav2 150px nav nav2 150px last"
Test getting and setting grid-definition-columns and grid-definition-rows through JS
PASS getComputedStyle(element, '').getPropertyValue('grid-definition-columns') is "first 18px"
@@ -68,12 +70,34 @@ PASS getComputedStyle(element, '').getPropertyValue('grid-definition-columns') i
PASS element.style.gridDefinitionColumns is "foo bar auto foo auto bar"
PASS getComputedStyle(element, '').getPropertyValue('grid-definition-rows') is "foo bar 0px foo 0px bar"
PASS element.style.gridDefinitionRows is "foo bar auto foo auto bar"
+PASS getComputedStyle(element, '').getPropertyValue('grid-definition-columns') is "first 0px foo bar 20px foo bar 20px"
+PASS element.style.gridDefinitionColumns is "first auto foo bar 20px foo bar 20px"
+PASS getComputedStyle(element, '').getPropertyValue('grid-definition-rows') is "220px foo 300px baz"
+PASS element.style.gridDefinitionRows is "220px foo 50% baz"
+
+Test getting invalid grid-definition-columns and grid-definition-rows set through CSS
+PASS window.getComputedStyle(gridWithoutParenthesesElement, '').getPropertyValue('grid-definition-columns') is "none"
+PASS window.getComputedStyle(gridWithoutParenthesesElement, '').getPropertyValue('grid-definition-rows') is "none"
+PASS window.getComputedStyle(gridWithInvalidNestedParenthesesElement, '').getPropertyValue('grid-definition-columns') is "none"
+PASS window.getComputedStyle(gridWithInvalidNestedParenthesesElement, '').getPropertyValue('grid-definition-rows') is "none"
+PASS window.getComputedStyle(gridWithUnbalancedParenthesesElement, '').getPropertyValue('grid-definition-columns') is "none"
+PASS window.getComputedStyle(gridWithUnbalancedParenthesesElement, '').getPropertyValue('grid-definition-rows') is "none"
+PASS window.getComputedStyle(gridWithMisplacedParenthesesElement, '').getPropertyValue('grid-definition-columns') is "none"
+PASS window.getComputedStyle(gridWithMisplacedParenthesesElement, '').getPropertyValue('grid-definition-rows') is "none"
Test getting and setting invalid grid-definition-columns and grid-definition-rows through JS
-PASS getComputedStyle(element, '').getPropertyValue('grid-definition-columns') is "none"
-PASS getComputedStyle(element, '').getPropertyValue('grid-definition-rows') is "none"
-PASS getComputedStyle(element, '').getPropertyValue('grid-definition-columns') is "none"
-PASS getComputedStyle(element, '').getPropertyValue('grid-definition-rows') is "none"
+PASS window.getComputedStyle(element, '').getPropertyValue('grid-definition-columns') is "none"
+PASS window.getComputedStyle(element, '').getPropertyValue('grid-definition-rows') is "none"
+PASS window.getComputedStyle(element, '').getPropertyValue('grid-definition-columns') is "none"
+PASS window.getComputedStyle(element, '').getPropertyValue('grid-definition-rows') is "none"
+PASS window.getComputedStyle(element, '').getPropertyValue('grid-definition-columns') is "none"
+PASS window.getComputedStyle(element, '').getPropertyValue('grid-definition-rows') is "none"
+PASS window.getComputedStyle(element, '').getPropertyValue('grid-definition-columns') is "none"
+PASS window.getComputedStyle(element, '').getPropertyValue('grid-definition-rows') is "none"
+PASS window.getComputedStyle(element, '').getPropertyValue('grid-definition-columns') is "none"
+PASS window.getComputedStyle(element, '').getPropertyValue('grid-definition-rows') is "none"
+PASS window.getComputedStyle(element, '').getPropertyValue('grid-definition-columns') is "none"
+PASS window.getComputedStyle(element, '').getPropertyValue('grid-definition-rows') is "none"
PASS successfullyParsed is true
TEST COMPLETE

Powered by Google App Engine
This is Rietveld 408576698