LayoutTests/fast/css-grid-layout/grid-item-bad-resolution-double-span.html - Issue 23528004: [CSS Grid Layout] Update named grid lines syntax to the last version of the specs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/css-grid-layout/grid-item-bad-resolution-double-span.html

Issue 23528004: [CSS Grid Layout] Update named grid lines syntax to the last version of the specs (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@named

Patch Set: New parsing based on rune's and jchaffraix's comments Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/css-grid-layout/grid-element-repeat-get-set.html ('k') | LayoutTests/fast/css-grid-layout/grid-item-named-grid-area-resolution.html » ('j') | LayoutTests/fast/css-grid-layout/named-grid-line-get-set.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/css-grid-layout/grid-item-bad-resolution-double-span.html

diff --git a/LayoutTests/fast/css-grid-layout/grid-item-bad-resolution-double-span.html b/LayoutTests/fast/css-grid-layout/grid-item-bad-resolution-double-span.html

index fccc8ab4097d422929bc0ca33e3604699d9f8d38..b23fa78b4f7b1e95c9d7436aa59b4aa0d760dab4 100644

--- a/LayoutTests/fast/css-grid-layout/grid-item-bad-resolution-double-span.html

+++ b/LayoutTests/fast/css-grid-layout/grid-item-bad-resolution-double-span.html

@@ -3,14 +3,14 @@

<style>

.grid {

- grid-definition-rows: "firstRow" 10px 20px;

- grid-definition-columns: "firstColumn" 30px 40px;

+ grid-definition-rows: (firstRow) 10px 20px;

+ grid-definition-columns: (firstColumn) 30px 40px;

grid-auto-flow: row;

}

.bothSpanRow {

grid-column: 1;

- grid-row: span 5 "firstRow" / span 1;

+ grid-row: span 5 (firstRow) / span 1;

}

.bothSpanColumn {

@@ -20,7 +20,7 @@

.spanAutoRow {

grid-column: 1;

- grid-row: span 5 "firstRow" / auto;

+ grid-row: span 5 (firstRow) / auto;

}

.spanAutoColumn {