Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2352793002: DevTools: Add Ctrl-A and Ctrl-E shortcuts to CodeMirror (Closed)

Created:
4 years, 3 months ago by einbinder
Modified:
4 years, 3 months ago
Reviewers:
dgozman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Add Ctrl-A and Ctrl-E shortcuts to CodeMirror On Mac, Ctrl-A and Ctrl-E go to the start and end of a line respectively. BUG=648331 Committed: https://crrev.com/cfc30f28e0bb2b16793188e670f109d81c8f153d Cr-Commit-Position: refs/heads/master@{#419610}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/text_editor/CodeMirrorTextEditor.js View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
einbinder
ptal
4 years, 3 months ago (2016-09-19 18:35:48 UTC) #2
dgozman
lgtm
4 years, 3 months ago (2016-09-19 23:26:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2352793002/1
4 years, 3 months ago (2016-09-20 00:26:52 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 00:35:29 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 00:37:34 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cfc30f28e0bb2b16793188e670f109d81c8f153d
Cr-Commit-Position: refs/heads/master@{#419610}

Powered by Google App Engine
This is Rietveld 408576698