Clean up TODOs in rasterize_and_record_micro.py

Clean up TODOs in rasterize_and_record_micro.py

BUG=648336
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Committed: https://crrev.com/8a8531e12bcc6df76cbfe95afc60c4ad59717868
Cr-Commit-Position: refs/heads/master@{#421055}

[wkorman, 2016-09-20 00:16:42]

Description was changed from

==========
Clean up TODOs in rasterize_and_record_micro.py

BUG=648336
==========

to

==========
Clean up TODOs in rasterize_and_record_micro.py

BUG=648336
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
==========

[wkorman, 2016-09-20 00:23:20]

wkorman@chromium.org changed reviewers:
+ nednguyen@chromium.org, schenney@chromium.org

[wkorman, 2016-09-20 00:23:21]

I haven't yet figured out how to run the unit tests. I found:

https://www.chromium.org/developers/telemetry/telemetry-unittests

but it looks out of date. I tried running:

% ./tools/perf/run_telemetry_tests RasterizeAndRecordMicroUnitTest.*
--no-browser
% ./tools/perf/run_tests RasterizeAndRecordMicroUnitTest.* --no-browser

and per comment at aforementioned page:

% ./third_party/catapult/telemetry/bin/run_tests
RasterizeAndRecordMicroUnitTest.* --no-browser

and initially I actually tried permutations without --no-browser, instead trying
to use a local content shell, or just 'dev'. They all give "No tests to run."
One of them did end up at least importing the modified script and finding a typo
I had made, which I fixed.

[Stephen Chennney, 2016-09-20 13:54:21]

I don't think I'm an OWNER, but LGTM from me.

Regarding storing in a "picture pile" named location, my guess is that I or
someone else was trying to have a conceptual correspondence with the picture
pile code path, so we could compare results somehow. Assuming the picture pile
code is gone, that data field could be renamed.

[nednguyen, 2016-09-20 14:12:23]

On 2016/09/20 00:23:21, wkorman wrote:
> I haven't yet figured out how to run the unit tests. I found:
> 
> https://www.chromium.org/developers/telemetry/telemetry-unittests
> 
> but it looks out of date. I tried running:
> 
> % ./tools/perf/run_telemetry_tests RasterizeAndRecordMicroUnitTest.*
> --no-browser
> % ./tools/perf/run_tests RasterizeAndRecordMicroUnitTest.* --no-browser
> 
> and per comment at aforementioned page:
> 
> % ./third_party/catapult/telemetry/bin/run_tests
> RasterizeAndRecordMicroUnitTest.* --no-browser
> 
> and initially I actually tried permutations without --no-browser, instead
trying
> to use a local content shell, or just 'dev'. They all give "No tests to run."
> One of them did end up at least importing the modified script and finding a
typo
> I had made, which I fixed.

Sorry for the outdated instruction, you can run the test with
./tools/perf/run_tests --browser=<...> rasterize_and_record_micro

[nednguyen, 2016-09-20 14:12:43]

On 2016/09/20 14:12:23, nednguyen wrote:
> On 2016/09/20 00:23:21, wkorman wrote:
> > I haven't yet figured out how to run the unit tests. I found:
> > 
> > https://www.chromium.org/developers/telemetry/telemetry-unittests
> > 
> > but it looks out of date. I tried running:
> > 
> > % ./tools/perf/run_telemetry_tests RasterizeAndRecordMicroUnitTest.*
> > --no-browser
> > % ./tools/perf/run_tests RasterizeAndRecordMicroUnitTest.* --no-browser
> > 
> > and per comment at aforementioned page:
> > 
> > % ./third_party/catapult/telemetry/bin/run_tests
> > RasterizeAndRecordMicroUnitTest.* --no-browser
> > 
> > and initially I actually tried permutations without --no-browser, instead
> trying
> > to use a local content shell, or just 'dev'. They all give "No tests to
run."
> > One of them did end up at least importing the modified script and finding a
> typo
> > I had made, which I fixed.
> 
> Sorry for the outdated instruction, you can run the test with
> ./tools/perf/run_tests --browser=<...> rasterize_and_record_micro

lgtm

Thanks for your clean up!

[wkorman, 2016-09-26 17:52:42]

The CQ bit was checked by wkorman@chromium.org

[wkorman, 2016-09-26 17:52:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
nednguyen@google.com, schenney@chromium.org
Link to the patchset: https://codereview.chromium.org/2352783004/#ps40001
(title: "Fix one more todo.")

[commit-bot: I haz the power, 2016-09-26 17:53:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 00:50:07]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-27 00:55:25]

Description was changed from

==========
Clean up TODOs in rasterize_and_record_micro.py

BUG=648336
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
==========

to

==========
Clean up TODOs in rasterize_and_record_micro.py

BUG=648336
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Committed: https://crrev.com/8a8531e12bcc6df76cbfe95afc60c4ad59717868
Cr-Commit-Position: refs/heads/master@{#421055}
==========

[commit-bot: I haz the power, 2016-09-27 00:55:26]

Patchset 3 (id:??) landed as
https://crrev.com/8a8531e12bcc6df76cbfe95afc60c4ad59717868
Cr-Commit-Position: refs/heads/master@{#421055}