Fix the scale of Drag and Drop shadow image.

Fix the scale of Drag and Drop shadow image.

Physical Pixel = CSS pixel * DIP scale * page scale.
In the case of our bitmap shadow image, page scale is not applied to it.

BUG=648413
Committed: https://crrev.com/adba2165f4c6e1c7d4a78179d6e066aa8e37f938
Cr-Commit-Position: refs/heads/master@{#420243}

[hush (inactive), 2016-09-20 18:21:03]

hush@chromium.org changed reviewers:
+ tedchoc@chromium.org

[hush (inactive), 2016-09-20 18:21:03]

Hello Ted, 
PTAL

[Ted C, 2016-09-20 20:05:24]

https://codereview.chromium.org/2352773003/diff/1/content/browser/web_content...
File content/browser/web_contents/web_contents_view_android.cc (right):

https://codereview.chromium.org/2352773003/diff/1/content/browser/web_content...
content/browser/web_contents/web_contents_view_android.cc:256: jtext,
gfx::ConvertToJavaBitmap(image.bitmap()), page_scale)) {
who generates the bitmap?

In this case, were we generating it to be too large?  If so, we should really
try to fix it at generation time to be scaled down to avoid passing a bigger
bitmap across to java (since it will use more memory for something we don't
actually need).

[hush (inactive), 2016-09-20 21:32:33]

https://codereview.chromium.org/2352773003/diff/1/content/browser/web_content...
File content/browser/web_contents/web_contents_view_android.cc (right):

https://codereview.chromium.org/2352773003/diff/1/content/browser/web_content...
content/browser/web_contents/web_contents_view_android.cc:256: jtext,
gfx::ConvertToJavaBitmap(image.bitmap()), page_scale)) {
On 2016/09/20 20:05:24, Ted C wrote:
> who generates the bitmap?
> 
> In this case, were we generating it to be too large?  If so, we should really
> try to fix it at generation time to be scaled down to avoid passing a bigger
> bitmap across to java (since it will use more memory for something we don't
> actually need).

Blink generates it here.
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/page/Drag...

It is not always bigger than what's needed though:
if page scale is < 1, the bitmap is bigger than necessary. Otherwise, it is
smaller than necessary.

[hush (inactive), 2016-09-20 22:09:09]

hush@chromium.org changed reviewers:
+ dcheng@chromium.org

[hush (inactive), 2016-09-20 22:09:09]

Hello Daniel, PTAL

[dcheng, 2016-09-20 22:17:24]

dcheng@chromium.org changed reviewers:
+ wjmaclean@chromium.org

[dcheng, 2016-09-20 22:17:24]

+wjmaclean for the review, he knows the scaling stuff better than me.

(I thought we were consolidating PSF and DSF? What happened to that?)

[wjmaclean, 2016-09-21 20:26:02]

On 2016/09/20 22:17:24, dcheng wrote:
> +wjmaclean for the review, he knows the scaling stuff better than me.
> 
> (I thought we were consolidating PSF and DSF? What happened to that?)

Page zoom levels and device scale factors have been consolidated (though still
behind a flag which is on for CrOS, not sure about where all else). But
PageScaleFactor and visual viewport are related to pinch-zoom, so it might be
worth getting bokan@ to confirm.

Based on the TODO in the code, I think this seems likes a perfectly reasonable
change for now.

lgtm

[wjmaclean, 2016-09-21 20:26:17]

Description was changed from

==========
Fix the scale of Drag and Drop shadow image.

Physical Pixel = CSS pixel * DIP scale * page scale.
In the case of our bitmap shadow image, page scale is not applied to it.

BUG=648413
==========

to

==========
Fix the scale of Drag and Drop shadow image.

Physical Pixel = CSS pixel * DIP scale * page scale.
In the case of our bitmap shadow image, page scale is not applied to it.

BUG=648413
==========

[wjmaclean, 2016-09-21 20:26:17]

wjmaclean@chromium.org changed reviewers:
+ bokan@chromium.org

[wjmaclean, 2016-09-21 20:26:40]

+ bokan@ in case he wants a look.

[hush (inactive), 2016-09-21 20:29:04]

The CQ bit was checked by hush@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 20:29:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bokan, 2016-09-21 21:02:16]

Change looks fine to me, could we get a test?

[commit-bot: I haz the power, 2016-09-21 21:47:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 21:47:28]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[hush (inactive), 2016-09-21 23:07:11]

On 2016/09/21 at 21:02:16, bokan wrote:
> Change looks fine to me, could we get a test?

Sure. I added a test in the latest patch set.

[bokan, 2016-09-21 23:08:25]

thanks, lgtm

[hush (inactive), 2016-09-21 23:31:06]

The CQ bit was checked by hush@chromium.org

[hush (inactive), 2016-09-21 23:31:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
wjmaclean@chromium.org
Link to the patchset: https://codereview.chromium.org/2352773003/#ps60001
(title: "space")

[commit-bot: I haz the power, 2016-09-21 23:31:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 02:27:21]

Description was changed from

==========
Fix the scale of Drag and Drop shadow image.

Physical Pixel = CSS pixel * DIP scale * page scale.
In the case of our bitmap shadow image, page scale is not applied to it.

BUG=648413
==========

to

==========
Fix the scale of Drag and Drop shadow image.

Physical Pixel = CSS pixel * DIP scale * page scale.
In the case of our bitmap shadow image, page scale is not applied to it.

BUG=648413
==========

[commit-bot: I haz the power, 2016-09-22 02:27:22]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-22 02:28:40]

Description was changed from

==========
Fix the scale of Drag and Drop shadow image.

Physical Pixel = CSS pixel * DIP scale * page scale.
In the case of our bitmap shadow image, page scale is not applied to it.

BUG=648413
==========

to

==========
Fix the scale of Drag and Drop shadow image.

Physical Pixel = CSS pixel * DIP scale * page scale.
In the case of our bitmap shadow image, page scale is not applied to it.

BUG=648413

Committed: https://crrev.com/adba2165f4c6e1c7d4a78179d6e066aa8e37f938
Cr-Commit-Position: refs/heads/master@{#420243}
==========

[commit-bot: I haz the power, 2016-09-22 02:28:41]

Patchset 4 (id:??) landed as
https://crrev.com/adba2165f4c6e1c7d4a78179d6e066aa8e37f938
Cr-Commit-Position: refs/heads/master@{#420243}