Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 2352753002: Collect more UMA data about dialogs and site engagement. (Closed)
Patch Set: nit Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « third_party/WebKit/public/web/WebUserGestureIndicator.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 1727ca2af1de172d509f753c4c577ae0f75a421b..3dd60034af41205b1509fccac75b363fb63785dc 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -102213,6 +102213,13 @@ To add a new entry, add it with any value and run test to compute valid value.
<affected-histogram name="DNS.PrefetchResolution"/>
</histogram_suffixes>
+<histogram_suffixes name="JSDialogs.DialogType" separator=".">
+ <suffix name="Alert"/>
+ <suffix name="Confirm"/>
+ <suffix name="Prompt"/>
+ <affected-histogram name="JSDialogs.SiteEngagementOfDialogs"/>
+</histogram_suffixes>
+
<histogram_suffixes name="JSDialogs.EngagementList" separator=".">
<suffix name="EngagementNone" label="site engagement = 0"/>
<suffix name="EngagementLessThanOne" label="site engagement &lt; 1"/>
@@ -102221,6 +102228,24 @@ To add a new entry, add it with any value and run test to compute valid value.
<affected-histogram name="JSDialogs.CharacterCount"/>
</histogram_suffixes>
+<histogram_suffixes name="JSDialogs.FrameType" separator=".">
+ <suffix name="MainFrame" label="dialog spawned by the main frame"/>
+ <suffix name="Subframe" label="dialog spawned by a subframe"/>
+ <affected-histogram name="JSDialogs.CharacterCount"/>
+</histogram_suffixes>
+
+<histogram_suffixes name="JSDialogs.LeaveStay" separator=".">
+ <suffix name="Leave" label="user opted to leave the page"/>
+ <suffix name="Stay" label="user opted to stay on the page"/>
+ <affected-histogram name="JSDialogs.SiteEngagementOfBeforeUnload"/>
+</histogram_suffixes>
+
+<histogram_suffixes name="JSDialogs.UserGestureSinceLoad" separator=".">
+ <suffix name="UserGestureSinceLoad"/>
+ <suffix name="NoUserGestureSinceLoad"/>
+ <affected-histogram name="JSDialogs.CharacterCount"/>
+</histogram_suffixes>
+
<histogram_suffixes name="LateBindingExperiment">
<suffix name="disable_late_binding" label="socket late binding is disabled"/>
<suffix name="enable_late_binding" label="socket late binding is enabled"/>
« no previous file with comments | « third_party/WebKit/public/web/WebUserGestureIndicator.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698