Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(141)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: LayoutTests/fast/forms/number/number-setvalueforuser-skip-spaces-expected.txt
Issue
235273003
:
parsing input type=number should skip spaces (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: incorporated review comments
Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
LayoutTests/fast/forms/number/number-setvalueforuser-skip-spaces.html
LayoutTests/fast/forms/number/number-setvalueforuser-skip-spaces-expected.txt
Source/platform/text/PlatformLocale.cpp
View unified diff
|
Download patch
« LayoutTests/fast/forms/number/number-setvalueforuser-skip-spaces.html
('K') |
« LayoutTests/fast/forms/number/number-setvalueforuser-skip-spaces.html
('k') |
Source/platform/text/PlatformLocale.cpp »
('j') |
Source/platform/text/PlatformLocale.cpp »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1
1
should print the input number removing space characters.
2
This tests that a hit test on a image map that has areas and anchors does not cr
ash
3
2
4 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE ".
3 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE ".
5
4
6
5
6
PASS spaces skipped
7 PASS successfullyParsed is true
7 PASS successfullyParsed is true
8
8
9 TEST COMPLETE
9 TEST COMPLETE
10
10
11
Printed Value: 123456
OLD
NEW
« LayoutTests/fast/forms/number/number-setvalueforuser-skip-spaces.html
('K') |
« LayoutTests/fast/forms/number/number-setvalueforuser-skip-spaces.html
('k') |
Source/platform/text/PlatformLocale.cpp »
('j') |
Source/platform/text/PlatformLocale.cpp »
('J')
Issue 235273003: parsing input type=number should skip spaces (Closed)
Created 6 years, 8 months ago by gnana
Modified 6 years, 8 months ago
Reviewers: tkent, keishi
Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Comments: 19
This is Rietveld
408576698