chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheControllerTest.java - Issue 2352713002: android: Mark flaky tests with @RetryOnFailure

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheControllerTest.java

Issue 2352713002: android: Mark flaky tests with @RetryOnFailure (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/UrlManagerTest.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheLauncherTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheControllerTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheControllerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheControllerTest.java

index 613fcbeebfaa2890d05543e382c415a3bb3846f5..d2eead8f7c455a71d5128402889c43fbf8602d3f 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheControllerTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheControllerTest.java

@@ -17,6 +17,7 @@ import org.chromium.base.ContextUtils;

import org.chromium.base.metrics.RecordHistogram;

import org.chromium.base.test.util.AdvancedMockContext;

import org.chromium.base.test.util.Feature;

+import org.chromium.base.test.util.RetryOnFailure;

import org.chromium.components.precache.MockDeviceState;

/**

@@ -221,6 +222,7 @@ public class PrecacheControllerTest extends InstrumentationTestCase {

@SmallTest

@Feature({"Precache"})

+ @RetryOnFailure

public void testDeviceStateChangeWhenNotPrecaching() {

assertFalse(mPrecacheController.isPrecaching());

mPrecacheController.setDeviceState(new MockDeviceState(0, false, true));

@@ -234,6 +236,7 @@ public class PrecacheControllerTest extends InstrumentationTestCase {

@SmallTest

@Feature({"Precache"})

+ @RetryOnFailure

public void testTimeoutCancelsPrecaching() {

verifyBeginPrecaching();