Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 2352703003: Remove stl_util's STLDeleteContainerPairSecondPointers from prefs. (Closed)

Created:
4 years, 3 months ago by Avi (use Gerrit)
Modified:
4 years, 3 months ago
Reviewers:
battre
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove stl_util's STLDeleteContainerPairSecondPointers from prefs. BUG=555865 Committed: https://crrev.com/a92d13b8279237e2a71290fca8c374fd7ec15881 Cr-Commit-Position: refs/heads/master@{#420002}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -28 lines) Patch
M components/prefs/pref_notifier_impl.h View 2 chunks +3 lines, -1 line 0 comments Download
M components/prefs/pref_notifier_impl.cc View 8 chunks +15 lines, -26 lines 0 comments Download
M components/prefs/pref_notifier_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
Avi (use Gerrit)
4 years, 3 months ago (2016-09-20 16:22:44 UTC) #5
battre
LGTM Thanks for the cleanup!
4 years, 3 months ago (2016-09-21 07:43:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2352703003/1
4 years, 3 months ago (2016-09-21 07:43:56 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 07:48:58 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 07:50:20 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a92d13b8279237e2a71290fca8c374fd7ec15881
Cr-Commit-Position: refs/heads/master@{#420002}

Powered by Google App Engine
This is Rietveld 408576698