Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2352683002:
Remove unused global variable with non-trivial constructor/destructor (Closed)
|
Created:
4 years, 3 months ago by kuznetsovs Modified:
4 years, 2 months ago CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove unused global variable with non-trivial constructor/destructor
After https://codereview.chromium.org/2257363002
I think it was added accidentally.
BUG=
Committed: https://crrev.com/44684fbb44ec7c1fe0c376a31a976d3cc80eec17
Cr-Commit-Position: refs/heads/master@{#421150}
Patch Set 1 #
Messages
Total messages: 18 (11 generated)
kuznetsovs@yandex-team.ru changed reviewers: + waffles@chromium.org
HI! This global variable leads to crashes in unit tests in our downstream code. I think it was added accidentally and potentially may lead to problems in upstream code too.
Description was changed from ========== Remove unused global variable with non-trivial constructor/destructor After https://codereview.chromium.org/2257363002 I think it was added accidentally. BUG= ========== to ========== Remove unused global variable with non-trivial constructor/destructor After https://codereview.chromium.org/2257363002 I think it was added accidentally. BUG= ==========
kuznetsovs@yandex-team.ru changed reviewers: + cpu@chromium.org, laforge@chromium.org
The CQ bit was checked by waffles@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
laforge@google.com changed reviewers: + sorin@chromium.org - cpu@chromium.org, laforge@chromium.org
lgtm
lgtm Accidentally indeed, thank you for the fix.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by kuznetsovs@yandex-team.ru
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Remove unused global variable with non-trivial constructor/destructor After https://codereview.chromium.org/2257363002 I think it was added accidentally. BUG= ========== to ========== Remove unused global variable with non-trivial constructor/destructor After https://codereview.chromium.org/2257363002 I think it was added accidentally. BUG= ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Remove unused global variable with non-trivial constructor/destructor After https://codereview.chromium.org/2257363002 I think it was added accidentally. BUG= ========== to ========== Remove unused global variable with non-trivial constructor/destructor After https://codereview.chromium.org/2257363002 I think it was added accidentally. BUG= Committed: https://crrev.com/44684fbb44ec7c1fe0c376a31a976d3cc80eec17 Cr-Commit-Position: refs/heads/master@{#421150} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/44684fbb44ec7c1fe0c376a31a976d3cc80eec17 Cr-Commit-Position: refs/heads/master@{#421150} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
