GN: remove old Android recipe code.

GN: remove old Android recipe code.

All the Android builders, testers, and perfers are on gn_android_flavor now.

Not as scary as it looks... all the big line count changes are deletes.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2352653002

Committed: https://skia.googlesource.com/skia/+/122fac306189940a4135e884eaef71a9aa0d5c8a

[mtklein_C, 2016-09-19 12:39:01]

Description was changed from

==========
GN: remove old Android recipe code.

All the Android builders, testers, and perfers are on gn_android_flavor now.

BUG=skia:
==========

to

==========
GN: remove old Android recipe code.

All the Android builders, testers, and perfers are on gn_android_flavor now.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2352653002
==========

[mtklein_C, 2016-09-19 12:42:38]

Description was changed from

==========
GN: remove old Android recipe code.

All the Android builders, testers, and perfers are on gn_android_flavor now.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2352653002
==========

to

==========
GN: remove old Android recipe code.

All the Android builders, testers, and perfers are on gn_android_flavor now.

Not as scary as it looks... all the big line count changes are deletes.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2352653002
==========

[mtklein_C, 2016-09-19 12:42:55]

mtklein@chromium.org changed reviewers:
+ borenet@google.com

[borenet, 2016-09-19 13:05:16]

LGTM. When can we rename GN_Android -> Android?

https://codereview.chromium.org/2352653002/diff/1/infra/bots/recipe_modules/f...
File infra/bots/recipe_modules/flavor/api.py (left):

https://codereview.chromium.org/2352653002/diff/1/infra/bots/recipe_modules/f...
infra/bots/recipe_modules/flavor/api.py:150: device_version = VERSION_NONE
Why is this safe to remove?

[mtklein, 2016-09-19 13:06:26]

mtklein@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2016-09-19 13:06:27]

https://codereview.chromium.org/2352653002/diff/1/infra/bots/recipe_modules/f...
File infra/bots/recipe_modules/flavor/api.py (left):

https://codereview.chromium.org/2352653002/diff/1/infra/bots/recipe_modules/f...
infra/bots/recipe_modules/flavor/api.py:150: device_version = VERSION_NONE
On 2016/09/19 13:05:15, borenet wrote:
> Why is this safe to remove?

No bots actually fail now.  I think they just return '/path/to/file not found'
as the "version", which never compares equal to the number we're looking for.

[mtklein, 2016-09-19 13:12:05]

On 2016/09/19 13:05:16, borenet wrote:
> LGTM. When can we rename GN_Android -> Android?

Any time!

There's no rush on my part though... it seemed cosmetic enough that I seemed
easy enough to kick down the road until the buildbot masters were gone.  If we
need to do it soon, it'd be the usual: update the recipes to handle both
-GN_Android and -Android, swap them all over in a buildbot master CL, then
update the code to forget about -GN_Android.

[mtklein, 2016-09-19 13:12:14]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2016-09-19 13:12:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[borenet, 2016-09-19 13:13:22]

https://codereview.chromium.org/2352653002/diff/1/infra/bots/recipe_modules/f...
File infra/bots/recipe_modules/flavor/api.py (left):

https://codereview.chromium.org/2352653002/diff/1/infra/bots/recipe_modules/f...
infra/bots/recipe_modules/flavor/api.py:150: device_version = VERSION_NONE
On 2016/09/19 13:06:27, mtklein wrote:
> On 2016/09/19 13:05:15, borenet wrote:
> > Why is this safe to remove?
> 
> No bots actually fail now.  I think they just return '/path/to/file not found'
> as the "version", which never compares equal to the number we're looking for.

Okay, I think I'd prefer to leave in this check since it's something we rely so
heavily on. This can't fail, eg. for iOS?

[mtklein, 2016-09-19 13:18:52]

On 2016/09/19 13:13:22, borenet wrote:
>
https://codereview.chromium.org/2352653002/diff/1/infra/bots/recipe_modules/f...
> File infra/bots/recipe_modules/flavor/api.py (left):
> 
>
https://codereview.chromium.org/2352653002/diff/1/infra/bots/recipe_modules/f...
> infra/bots/recipe_modules/flavor/api.py:150: device_version = VERSION_NONE
> On 2016/09/19 13:06:27, mtklein wrote:
> > On 2016/09/19 13:05:15, borenet wrote:
> > > Why is this safe to remove?
> > 
> > No bots actually fail now.  I think they just return '/path/to/file not
found'
> > as the "version", which never compares equal to the number we're looking
for.
> 
> Okay, I think I'd prefer to leave in this check since it's something we rely
so
> heavily on. This can't fail, eg. for iOS?

I'm not sure we do rely on it.  I removed the "let's test read-file failure"
tests because they weren't failing, and then removed this branch because it was
no longer covered.  All lines of code in all remaining flavors are covered, and
none of them brought us to a failure here.

[borenet, 2016-09-19 13:33:21]

On 2016/09/19 13:18:52, mtklein wrote:
> On 2016/09/19 13:13:22, borenet wrote:
> >
>
https://codereview.chromium.org/2352653002/diff/1/infra/bots/recipe_modules/f...
> > File infra/bots/recipe_modules/flavor/api.py (left):
> > 
> >
>
https://codereview.chromium.org/2352653002/diff/1/infra/bots/recipe_modules/f...
> > infra/bots/recipe_modules/flavor/api.py:150: device_version = VERSION_NONE
> > On 2016/09/19 13:06:27, mtklein wrote:
> > > On 2016/09/19 13:05:15, borenet wrote:
> > > > Why is this safe to remove?
> > > 
> > > No bots actually fail now.  I think they just return '/path/to/file not
> found'
> > > as the "version", which never compares equal to the number we're looking
> for.
> > 
> > Okay, I think I'd prefer to leave in this check since it's something we rely
> so
> > heavily on. This can't fail, eg. for iOS?
> 
> I'm not sure we do rely on it.  I removed the "let's test read-file failure"
> tests because they weren't failing, and then removed this branch because it
was
> no longer covered.  All lines of code in all remaining flavors are covered,
and
> none of them brought us to a failure here.

I meant that we rely on the skp/skimage/svg install flow heavily. If the iOS
flavor correctly fails to read the file on the device when it doesn't exist,
this will cause us to fail out instead of installing the asset as we'd expect.

[mtklein, 2016-09-19 13:34:23]

On 2016/09/19 13:33:21, borenet wrote:
> On 2016/09/19 13:18:52, mtklein wrote:
> > On 2016/09/19 13:13:22, borenet wrote:
> > >
> >
>
https://codereview.chromium.org/2352653002/diff/1/infra/bots/recipe_modules/f...
> > > File infra/bots/recipe_modules/flavor/api.py (left):
> > > 
> > >
> >
>
https://codereview.chromium.org/2352653002/diff/1/infra/bots/recipe_modules/f...
> > > infra/bots/recipe_modules/flavor/api.py:150: device_version = VERSION_NONE
> > > On 2016/09/19 13:06:27, mtklein wrote:
> > > > On 2016/09/19 13:05:15, borenet wrote:
> > > > > Why is this safe to remove?
> > > > 
> > > > No bots actually fail now.  I think they just return '/path/to/file not
> > found'
> > > > as the "version", which never compares equal to the number we're looking
> > for.
> > > 
> > > Okay, I think I'd prefer to leave in this check since it's something we
rely
> > so
> > > heavily on. This can't fail, eg. for iOS?
> > 
> > I'm not sure we do rely on it.  I removed the "let's test read-file failure"
> > tests because they weren't failing, and then removed this branch because it
> was
> > no longer covered.  All lines of code in all remaining flavors are covered,
> and
> > none of them brought us to a failure here.
> 
> I meant that we rely on the skp/skimage/svg install flow heavily. If the iOS
> flavor correctly fails to read the file on the device when it doesn't exist,
> this will cause us to fail out instead of installing the asset as we'd expect.

How do we write a test that gets to device_version = VERSION_NONE?

[mtklein, 2016-09-19 13:40:50]

The CQ bit was unchecked by mtklein@google.com

[mtklein, 2016-09-19 13:41:08]

On 2016/09/19 13:34:23, mtklein wrote:
> On 2016/09/19 13:33:21, borenet wrote:
> > On 2016/09/19 13:18:52, mtklein wrote:
> > > On 2016/09/19 13:13:22, borenet wrote:
> > > >
> > >
> >
>
https://codereview.chromium.org/2352653002/diff/1/infra/bots/recipe_modules/f...
> > > > File infra/bots/recipe_modules/flavor/api.py (left):
> > > > 
> > > >
> > >
> >
>
https://codereview.chromium.org/2352653002/diff/1/infra/bots/recipe_modules/f...
> > > > infra/bots/recipe_modules/flavor/api.py:150: device_version =
VERSION_NONE
> > > > On 2016/09/19 13:06:27, mtklein wrote:
> > > > > On 2016/09/19 13:05:15, borenet wrote:
> > > > > > Why is this safe to remove?
> > > > > 
> > > > > No bots actually fail now.  I think they just return '/path/to/file
not
> > > found'
> > > > > as the "version", which never compares equal to the number we're
looking
> > > for.
> > > > 
> > > > Okay, I think I'd prefer to leave in this check since it's something we
> rely
> > > so
> > > > heavily on. This can't fail, eg. for iOS?
> > > 
> > > I'm not sure we do rely on it.  I removed the "let's test read-file
failure"
> > > tests because they weren't failing, and then removed this branch because
it
> > was
> > > no longer covered.  All lines of code in all remaining flavors are
covered,
> > and
> > > none of them brought us to a failure here.
> > 
> > I meant that we rely on the skp/skimage/svg install flow heavily. If the iOS
> > flavor correctly fails to read the file on the device when it doesn't exist,
> > this will cause us to fail out instead of installing the asset as we'd
expect.
> 
> How do we write a test that gets to device_version = VERSION_NONE?

Like PS 2?

[mtklein_C, 2016-09-19 13:49:23]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 13:49:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[borenet, 2016-09-19 14:03:37]

LGTM, thanks

[mtklein_C, 2016-09-19 14:07:13]

The CQ bit was unchecked by mtklein@chromium.org

[mtklein_C, 2016-09-19 14:07:19]

The CQ bit was checked by mtklein@chromium.org

[commit-bot: I haz the power, 2016-09-19 14:07:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 14:26:44]

Description was changed from

==========
GN: remove old Android recipe code.

All the Android builders, testers, and perfers are on gn_android_flavor now.

Not as scary as it looks... all the big line count changes are deletes.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2352653002
==========

to

==========
GN: remove old Android recipe code.

All the Android builders, testers, and perfers are on gn_android_flavor now.

Not as scary as it looks... all the big line count changes are deletes.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2352653002

Committed:
https://skia.googlesource.com/skia/+/122fac306189940a4135e884eaef71a9aa0d5c8a
==========

[commit-bot: I haz the power, 2016-09-19 14:26:45]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/122fac306189940a4135e884eaef71a9aa0d5c8a