Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2352633002: Fix the computation of the usage metric in UserClassifier. (Closed)

Created:
4 years, 3 months ago by jkrcal
Modified:
4 years, 3 months ago
Reviewers:
Marc Treib
CC:
chromium-reviews, ntp-dev+reviews_chromium.org, Bernhard Bauer
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the computation of the usage metric. Before this CL, the computation in UserClassifier::UpdateMetricOnEvent() did not reflect the math outlined in the same function. This CL fixes the problem. BUG=648200 Committed: https://crrev.com/452fd4f3321cfd3ade96518e53ac236969a90a75 Cr-Commit-Position: refs/heads/master@{#419437}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M components/ntp_snippets/user_classifier.cc View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
jkrcal
Hey, Marc, could you PTAL at this one missing "-" sign? (Bernhard who reviewed it ...
4 years, 3 months ago (2016-09-19 11:24:49 UTC) #3
Marc Treib
lgtm Description nit: If you describe the state before this CL, I prefer past tense ...
4 years, 3 months ago (2016-09-19 11:37:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2352633002/1
4 years, 3 months ago (2016-09-19 11:41:07 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-19 12:29:17 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 12:31:47 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/452fd4f3321cfd3ade96518e53ac236969a90a75
Cr-Commit-Position: refs/heads/master@{#419437}

Powered by Google App Engine
This is Rietveld 408576698