Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2158)

Unified Diff: chrome/common/extensions/docs/static/js/samples.js

Issue 23526077: [DocServer] Fixed Sample Links (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed all feedback Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/docs/static/js/samples.js
diff --git a/chrome/common/extensions/docs/static/js/samples.js b/chrome/common/extensions/docs/static/js/samples.js
index 6388205733b3ab368ca2e94556200a7eb642afce..77e64d93040a6322729e57d31d0547d43be06a2c 100644
--- a/chrome/common/extensions/docs/static/js/samples.js
+++ b/chrome/common/extensions/docs/static/js/samples.js
@@ -3,26 +3,28 @@
// found in the LICENSE file.
(function() {
- var search_box = document.getElementById('search_input');
+ var searchBox = document.getElementById('search_input');
var samples = document.getElementsByClassName('sample');
function filterSamples() {
- var search_text = search_box.value.toLowerCase();
+ var searchText = searchBox.value.toLowerCase();
for (var i = 0; i < samples.length; ++i) {
- var sample = samples[i]
- if (sample.getAttribute('tags').toLowerCase().indexOf(search_text) < 0)
+ var sample = samples[i];
+ var sampleTitle = sample.getElementsByTagName('h2')[0].textContent;
not at google - send to devlin 2013/09/25 17:33:08 I sure hope that sample.getElementsByTagName('h2')
François Beaufort 2013/09/26 10:27:28 You're right. I should check it's not empty. On 2
+ if (sample.getAttribute('tags').toLowerCase().indexOf(searchText) < 0 &&
+ sampleTitle.toLowerCase().indexOf(searchText) < 0)
sample.style.display = 'none';
else
sample.style.display = '';
}
}
- search_box.addEventListener('search', filterSamples);
- search_box.addEventListener('keyup', filterSamples);
+ searchBox.addEventListener('search', filterSamples);
+ searchBox.addEventListener('keyup', filterSamples);
- var api_filter_items = document.getElementById('api_filter_items');
- api_filter_items.addEventListener('click', function(event) {
+ var apiFilterItems = document.getElementById('api_filter_items');
+ apiFilterItems.addEventListener('click', function(event) {
if (event.target instanceof HTMLAnchorElement) {
- search_box.value = event.target.innerText;
+ searchBox.value = event.target.innerText;
filterSamples();
}
});

Powered by Google App Engine
This is Rietveld 408576698