[DocServer] Fixed Sample Links

chrome/common/extensions/docs/static/js/samples.js

Index: chrome/common/extensions/docs/static/js/samples.js
diff --git a/chrome/common/extensions/docs/static/js/samples.js b/chrome/common/extensions/docs/static/js/samples.js
index 6388205733b3ab368ca2e94556200a7eb642afce..76c09b599e1c5ef826ae98f9e2ade01f1946c053 100644
--- a/chrome/common/extensions/docs/static/js/samples.js
+++ b/chrome/common/extensions/docs/static/js/samples.js
@@ -9,8 +9,10 @@
   function filterSamples() {
     var search_text = search_box.value.toLowerCase();
     for (var i = 0; i < samples.length; ++i) {
-      var sample = samples[i]
-      if (sample.getAttribute('tags').toLowerCase().indexOf(search_text) < 0)
+      var sample = samples[i];
+      var sample_title = samples[i].getElementsByTagName('h2')[0].innerText;
+      if (sample.getAttribute('tags').toLowerCase().indexOf(search_text) < 0 &&
+          sample_title.toLowerCase().indexOf(search_text) < 0)
         sample.style.display = 'none';
       else
         sample.style.display = '';
@@ -26,4 +28,14 @@
       filterSamples();
     }
   });
+
+  function onLoad() {
+    var search = window.location.hash.substr(1).replace(/-/g, ' ');
+    if (search) {
+      search_box.value = search;
+      filterSamples();
+    }
+  }
+
+  window.addEventListener('DOMContentLoaded', onLoad);

[not at google - send to devlin, 2013/09/23 15:59:51]

the onLoad is hopefully unnecessary since the relevant DOM will have loaded by
the time this script executes.

however, I don't think we should hide the samples this way anyway: I don't like
executing JS on the client (keep it to an absolute minimum) and if we're loading
all this content anyway we might as well just show it. anchor is fine. If you
want to only show a single sample (and that sounds good to me actually) then we
should make it part of the actual URL in some way, so that the server only need
to render that particular sample.

could you file a but on that? there are a couple of different ways to do it and
a quick look on a bug would resolve it rather than doing it here.

[François Beaufort, 2013/09/24 09:24:49]

Done.

 })();