[DocServer] Fixed Sample Links

chrome/common/extensions/docs/server2/samples_data_source.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import hashlib
 import json
 import logging
 import re
 
 from compiled_file_system import CompiledFileSystem
@@ skipping 133 matching lines @@
           icon_base = sample_base_path
           download_url = sample_base_path + '.zip'
 
         manifest_data = self._GetDataFromManifest(sample_path, file_system)
         if manifest_data['icon'] is None:
           icon_path = '%s/static/%s' % (self._base_path, DEFAULT_ICON_PATH)
         else:
           icon_path = '%s/%s' % (icon_base, manifest_data['icon'])
         manifest_data.update({
           'icon': icon_path,
-          'id': hashlib.md5(url).hexdigest(),
           'download_url': download_url,
           'url': url,
           'files': [f.replace(sample_path + '/', '') for f in sample_files],
           'api_calls': api_calls
         })
         samples_list.append(manifest_data)
 
       return samples_list
 
   def __init__(self,
                extensions_cache,
                apps_cache,
                extension_samples_path,
                base_path,
                request):
     self._extensions_cache = extensions_cache
     self._apps_cache = apps_cache
     self._extension_samples_path = extension_samples_path
     self._base_path = base_path
     self._request = request
 
+  def _GetSampleId(self, sample_name):
+    return sample_name.lower().replace(' ', '-')
+
   def _GetAcceptedLanguages(self):
     accept_language = self._request.headers.get('Accept-Language', None)
     if accept_language is None:
       return []
     return [lang_with_q.split(';')[0].strip()
             for lang_with_q in accept_language.split(',')]
 
   def FilterSamples(self, key, api_name):
     '''Fetches and filters the list of samples specified by |key|, returning
     only the samples that use the API |api_name|. |key| is either 'apps' or
@@ skipping 34 matching lines @@
           name_key = name[len('__MSG_'):-len('__')]
           description_key = description[len('__MSG_'):-len('__')]
           locale = sample_data['default_locale']
           for lang in self._GetAcceptedLanguages():
             if lang in sample_data['locales']:
               locale = lang
               break
           locale_data = sample_data['locales'][locale]
           sample_data['name'] = locale_data[name_key]['message']
           sample_data['description'] = locale_data[description_key]['message']
+          sample_data['id'] = self._GetSampleId(sample_data['name'])
         except Exception as e:
           logging.error(e)

[not at google - send to devlin, 2013/09/23 15:59:51]

incremental cleanup:

except:
  logging.error(traceback.format_exc())
  ...

[François Beaufort, 2013/09/24 09:24:49]

Done.

           # Revert the sample to the original dict.
           sample_data = dict_
         return_list.append(sample_data)
       else:
+        dict_['id'] = self._GetSampleId(name)
         return_list.append(dict_)
     return return_list
 
   def get(self, key):
     return {
       'apps': lambda: self._CreateSamplesDict('apps'),
       'extensions': lambda: self._CreateSamplesDict('extensions')
     }.get(key, lambda: {})()