Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 23526076: [Retry] SyncFS: Support resolveLocalFileSystemURL on SyncFileSystem (Closed)

Created:
7 years, 3 months ago by nhiroki
Modified:
7 years, 3 months ago
Reviewers:
kinuko, Tom Sepez, tzik
CC:
chromium-reviews, tzik+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, nhiroki+watch_chromium.org, kinuko+watch
Visibility:
Public.

Description

[Retry] SyncFS: Support resolveLocalFileSystemURL on SyncFileSystem Original review: https://codereview.chromium.org/23856002/ window.resolveLocalFileSystemURL is originally defined only for FileSystem API, but it'd be nice if it works on SyncFileSystem in a similar way. For that this change adds new IPC messages and interfaces. Blink side change depends on this: https://codereview.chromium.org/23537011/ BUG=177137, 294502 TEST=manual (Get FileSystemURL for a file on SyncFS, and then resolve it) TEST=unit_tests TEST=run_webkit_tests.sh http/tests/filesystem/\* TEST=run_webkit_tests.sh http/tests/inspector/filesystem/\* TBR=tsepez@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224542

Patch Set 1 #

Patch Set 2 : revoke SyncFS in the dtor of its backend #

Patch Set 3 : fix file path handling for win #

Patch Set 4 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+306 lines, -53 lines) Patch
M chrome/browser/sync_file_system/local/local_file_sync_context.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/local/sync_file_system_backend.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/sync_file_system_service_factory.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/sync_file_system/syncable_file_system_util_unittest.cc View 1 chunk +0 lines, -38 lines 0 comments Download
M content/browser/fileapi/fileapi_message_filter.h View 3 chunks +9 lines, -1 line 0 comments Download
M content/browser/fileapi/fileapi_message_filter.cc View 4 chunks +38 lines, -2 lines 0 comments Download
M content/child/fileapi/file_system_dispatcher.h View 4 chunks +12 lines, -0 lines 0 comments Download
M content/child/fileapi/file_system_dispatcher.cc View 8 chunks +38 lines, -0 lines 0 comments Download
M content/child/fileapi/webfilesystem_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/child/fileapi/webfilesystem_impl.cc View 1 2 3 3 chunks +35 lines, -1 line 0 comments Download
M content/common/fileapi/file_system_messages.h View 4 chunks +17 lines, -0 lines 0 comments Download
M webkit/browser/fileapi/file_system_context.h View 5 chunks +23 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/file_system_context.cc View 5 chunks +66 lines, -2 lines 0 comments Download
A webkit/common/fileapi/file_system_info.h View 1 chunk +31 lines, -0 lines 0 comments Download
A webkit/common/fileapi/file_system_info.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M webkit/common/fileapi/file_system_util.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/storage_common.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
nhiroki
Can you review this? (patch#1 is original). Thanks!
7 years, 3 months ago (2013-09-20 04:52:11 UTC) #1
tzik
lgtm
7 years, 3 months ago (2013-09-20 04:55:37 UTC) #2
nhiroki
Can you take another look? I fixed file path handling since on Win a file ...
7 years, 3 months ago (2013-09-20 05:32:14 UTC) #3
kinuko
On 2013/09/20 05:32:14, nhiroki wrote: > Can you take another look? > > I fixed ...
7 years, 3 months ago (2013-09-20 05:39:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/23526076/29001
7 years, 3 months ago (2013-09-20 06:47:38 UTC) #5
nhiroki
TBR-ing tsepez@ since IPC message and permission check are not changed from the original.
7 years, 3 months ago (2013-09-20 06:52:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/23526076/29001
7 years, 3 months ago (2013-09-20 06:52:37 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=199938
7 years, 3 months ago (2013-09-20 12:01:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/23526076/29001
7 years, 3 months ago (2013-09-20 14:03:10 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=200071
7 years, 3 months ago (2013-09-20 18:04:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/23526076/29001
7 years, 3 months ago (2013-09-21 01:03:11 UTC) #11
commit-bot: I haz the power
7 years, 3 months ago (2013-09-21 01:06:59 UTC) #12
Message was sent while issue was closed.
Change committed as 224542

Powered by Google App Engine
This is Rietveld 408576698