Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 23526073: Prevent test-log.cc from creating log files. (Closed)

Created:
7 years, 3 months ago by Michael Starzinger
Modified:
7 years, 3 months ago
Reviewers:
dcarney
CC:
v8-dev
Visibility:
Public.

Description

Prevent test-log.cc from creating log files. R=dcarney@chromium.org TEST=cctest/test-log/EquivalenceOfLoggingAndTraversal Committed: http://code.google.com/p/v8/source/detail?r=16852

Patch Set 1 #

Patch Set 2 : Minor cleanup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M src/flag-definitions.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/log.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M test/cctest/test-log.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
7 years, 3 months ago (2013-09-19 15:13:57 UTC) #1
dcarney
lgtm
7 years, 3 months ago (2013-09-20 08:39:28 UTC) #2
Michael Starzinger
7 years, 3 months ago (2013-09-20 08:49:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r16852 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698