Chromium Code Reviews| Index: gm/gmmain.cpp |
| =================================================================== |
| --- gm/gmmain.cpp (revision 11353) |
| +++ gm/gmmain.cpp (working copy) |
| @@ -905,6 +905,9 @@ |
| * See comments above complete_bitmap() for more detail. |
| */ |
| Expectations expectations = expectationsSource->get(nameWithExtension.c_str()); |
| + if (gm->isIgnoringFailures()) { |
| + expectations.setIgnoreFailure(true); |
| + } |
| errors.add(compare_to_expectations(expectations, *actualBitmapAndDigest, |
| gm->shortName(), configName, "", true)); |
| } else { |
| @@ -1380,6 +1383,8 @@ |
| DEFINE_string(ignoreErrorTypes, kDefaultIgnorableErrorTypes.asString(" ").c_str(), |
| "Space-separated list of ErrorTypes that should be ignored. If any *other* error " |
| "types are encountered, the tool will exit with a nonzero return value."); |
| +DEFINE_string(ignoreTests, "", "Space delimited list of tests for which we should ignore " |
| + "failures."); |
| DEFINE_string(match, "", "[~][^]substring[$] [...] of test name to run.\n" |
| "Multiple matches may be separated by spaces.\n" |
| "~ causes a matching test to always be skipped\n" |
| @@ -2163,6 +2168,9 @@ |
| if (SkCommandLineFlags::ShouldSkip(FLAGS_match, shortName)) { |
| continue; |
| } |
| + if (FLAGS_ignoreTests.contains(shortName)) { |
|
epoger
2013/09/18 20:10:35
Patchset 3: if the --ignoreTests flag has been pas
scroggo
2013/09/18 20:16:54
Might it make sense to allow pattern matching? (If
epoger
2013/09/19 06:16:36
That's a worthy suggestion, thanks. As per https:
|
| + gm->setIgnoreFailures(true); |
| + } |
| gmsRun++; |
| SkISize size = gm->getISize(); |