Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 23526052: Include What You Use: #include <errno.h> where errno is used, or use DPLOG (Closed)

Created:
7 years, 3 months ago by Mark Mentovai
Modified:
7 years, 3 months ago
Reviewers:
Nico
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Include What You Use: #include <errno.h> where errno is used, or use DPLOG R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223370

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M base/files/memory_mapped_file_posix.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M rlz/lib/recursive_cross_process_lock_posix.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark Mentovai
base + rlz = you
7 years, 3 months ago (2013-09-16 17:02:12 UTC) #1
Nico
7 years, 3 months ago (2013-09-16 18:29:12 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698