Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Side by Side Diff: Source/bindings/v8/custom/V8HTMLFormControlsCollectionCustom.cpp

Issue 23526039: Replace several uses of toWebCoreString() by V8TRYCATCH_FOR_V8STRINGRESOURCE() macro (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 return v8Undefined(); 49 return v8Undefined();
50 50
51 if (namedItems.size() == 1) 51 if (namedItems.size() == 1)
52 return toV8(namedItems.at(0).release(), callbackInfo.Holder(), callbackI nfo.GetIsolate()); 52 return toV8(namedItems.at(0).release(), callbackInfo.Holder(), callbackI nfo.GetIsolate());
53 53
54 return toV8(collection->ownerNode()->radioNodeList(name).get(), callbackInfo .Holder(), callbackInfo.GetIsolate()); 54 return toV8(collection->ownerNode()->radioNodeList(name).get(), callbackInfo .Holder(), callbackInfo.GetIsolate());
55 } 55 }
56 56
57 void V8HTMLFormControlsCollection::namedItemMethodCustom(const v8::FunctionCallb ackInfo<v8::Value>& args) 57 void V8HTMLFormControlsCollection::namedItemMethodCustom(const v8::FunctionCallb ackInfo<v8::Value>& args)
58 { 58 {
59 V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, name, args[0]);
59 HTMLFormControlsCollection* imp = V8HTMLFormControlsCollection::toNative(arg s.Holder()); 60 HTMLFormControlsCollection* imp = V8HTMLFormControlsCollection::toNative(arg s.Holder());
60 v8::Handle<v8::Value> result = getNamedItems(imp, toWebCoreString(args[0]), args); 61 v8::Handle<v8::Value> result = getNamedItems(imp, name, args);
61 62
62 if (result.IsEmpty()) { 63 if (result.IsEmpty()) {
63 v8SetReturnValueNull(args); 64 v8SetReturnValueNull(args);
64 return; 65 return;
65 } 66 }
66 67
67 v8SetReturnValue(args, result); 68 v8SetReturnValue(args, result);
68 } 69 }
69 70
70 } // namespace WebCore 71 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698