Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Side by Side Diff: Source/bindings/v8/custom/V8DocumentLocationCustom.cpp

Issue 23526039: Replace several uses of toWebCoreString() by V8TRYCATCH_FOR_V8STRINGRESOURCE() macro (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Harri Porten (porten@kde.org) 2 * Copyright (C) 2000 Harri Porten (porten@kde.org)
3 * Copyright (C) 2001 Peter Kelly (pmk@post.com) 3 * Copyright (C) 2001 Peter Kelly (pmk@post.com)
4 * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc. 4 * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc.
5 * Copyright (C) 2006 James G. Speth (speth@end.com) 5 * Copyright (C) 2006 James G. Speth (speth@end.com)
6 * Copyright (C) 2006 Samuel Weinig (sam@webkit.org) 6 * Copyright (C) 2006 Samuel Weinig (sam@webkit.org)
7 * Copyright (C) 2007, 2008, 2009 Google Inc. All Rights Reserved. 7 * Copyright (C) 2007, 2008, 2009 Google Inc. All Rights Reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Lesser General Public 10 * modify it under the terms of the GNU Lesser General Public
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 51
52 DOMWindow* active = activeDOMWindow(); 52 DOMWindow* active = activeDOMWindow();
53 if (!active) 53 if (!active)
54 return; 54 return;
55 55
56 DOMWindow* first = firstDOMWindow(); 56 DOMWindow* first = firstDOMWindow();
57 if (!first) 57 if (!first)
58 return; 58 return;
59 59
60 DOMWindow* window = document->domWindow(); 60 DOMWindow* window = document->domWindow();
61 if (Location* location = window->location()) 61 if (Location* location = window->location()) {
62 location->setHref(active, first, toWebCoreString(value)); 62 V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, stringValue, va lue);
63 location->setHref(active, first, stringValue);
64 }
63 } 65 }
64 66
65 } // namespace WebCore 67 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698