Move source files from webkit/support to content/test

Move source files from webkit/support to content/test

BUG=265753
TEST=content_unittests, webkit_unit_tests, content_shell
R=jamesr@chromium.org,tkent@chromium.org,jochen@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223201

[tfarina, 2013-09-07 00:15:15]

I looked into doing the namespace conversion to content, but that will look
messy, so I don't plan to do this in this patch.

please, take a look.

thanks!

[tfarina, 2013-09-07 00:16:19]

do'h forgot to try webkit_unit_tests. it is not linking yet. looking into this
right now.

[tfarina, 2013-09-07 00:24:58]

Done, webkit_unit_tests is linking again.

[Avi (use Gerrit), 2013-09-07 01:52:14]

If this is just moving files around, stampity stamp LGTM

[tkent, 2013-09-08 21:06:29]

lgtm

[commit-bot: I haz the power, 2013-09-08 21:57:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/23526028/9001

[commit-bot: I haz the power, 2013-09-08 22:21:21]

Retried try job too often on ios_dbg_simulator for step(s) base_unittests,
compile, content_unittests, crypto_unittests, net_unittests, sql_unittests,
ui_unittests, url_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[commit-bot: I haz the power, 2013-09-09 02:00:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/23526028/33001

[commit-bot: I haz the power, 2013-09-09 02:24:28]

Retried try job too often on ios_dbg_simulator for step(s) base_unittests,
compile, content_unittests, crypto_unittests, net_unittests, sql_unittests,
ui_unittests, url_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[commit-bot: I haz the power, 2013-09-09 02:27:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/23526028/33001

[commit-bot: I haz the power, 2013-09-09 02:47:10]

Retried try job too often on ios_dbg_simulator for step(s) base_unittests,
compile, content_unittests, crypto_unittests, net_unittests, sql_unittests,
ui_unittests, url_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[tfarina, 2013-09-09 03:19:25]

No idea what is going on with this trybot. I don't see how my patch could be
related to loading libjpeg.gyp

[tfarina, 2013-09-09 16:23:05]

Looking at the mac failure I realize that I can (need to) remove
webkit/support/webkit_support.gypi. Will do when I get back home later tonight.

[commit-bot: I haz the power, 2013-09-09 23:09:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/23526028/4038

[commit-bot: I haz the power, 2013-09-09 23:27:29]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[tfarina, 2013-09-09 23:32:47]

James, could you rubber stamp this for webkit/glue/webkit_glue.gypi?

[jamesr, 2013-09-10 00:16:27]

lgtm with pleasure!

[commit-bot: I haz the power, 2013-09-10 01:11:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/23526028/4038

[commit-bot: I haz the power, 2013-09-10 01:41:45]

Retried try job too often on ios_rel_device for step(s) compile
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_rel_de...

[tfarina, 2013-09-10 01:48:58]

Stuart, do you know what in my patch could be breaking ios_rel_device? It is not
happy with it yet :(

[tfarina, 2013-09-10 22:02:05]

Any suggestion guys?

Should I reduce the scope of this CL to prevent the change of issues like this
pop up?

[stuartmorgan, 2013-09-10 23:04:43]

You cannot (until the long-term project to extract all iOS code from content/ is
finished) unconditionally depend on webkit in content, if the target is built on
iOS.

https://codereview.chromium.org/23526028/diff/4038/content/content_tests.gypi
File content/content_tests.gypi (right):

https://codereview.chromium.org/23526028/diff/4038/content/content_tests.gypi...
content/content_tests.gypi:23:
'../webkit/support/webkit_support.gyp:glue_child',
These webkit deps...

https://codereview.chromium.org/23526028/diff/4038/content/content_tests.gypi...
content/content_tests.gypi:224:
'../webkit/storage_common.gyp:webkit_storage_common',
... need to go here.

[tfarina, 2013-09-10 23:49:56]

Thanks Stuart!

Please, could you take another look?

[stuartmorgan, 2013-09-11 14:41:28]

https://codereview.chromium.org/23526028/diff/15001/content/content_tests.gypi
File content/content_tests.gypi (right):

https://codereview.chromium.org/23526028/diff/15001/content/content_tests.gyp...
content/content_tests.gypi:174: },{ # OS!="mac"
Ideally this step shouldn't be done on iOS, since it's pointless there.

https://codereview.chromium.org/23526028/diff/15001/content/content_tests.gyp...
content/content_tests.gypi:179:
'../webkit/tools/test_shell/resources/textAreaResizeCorner.png',
Consider a variable for this array, rather than duplicating a file list; this is
more trouble to maintain, and more error prone as a result.

[tfarina, 2013-09-11 21:51:55]

Stuart, please, see if patch set 7 is what you want.

Thanks!

https://codereview.chromium.org/23526028/diff/15001/content/content_tests.gypi
File content/content_tests.gypi (right):

https://codereview.chromium.org/23526028/diff/15001/content/content_tests.gyp...
content/content_tests.gypi:179:
'../webkit/tools/test_shell/resources/textAreaResizeCorner.png',
On 2013/09/11 14:41:29, stuartmorgan wrote:
> Consider a variable for this array, rather than duplicating a file list; this
is
> more trouble to maintain, and more error prone as a result.
not sure how this improves anything.

[tfarina, 2013-09-12 22:55:57]

Stuart, ping?!

[stuartmorgan, 2013-09-13 00:15:54]

https://codereview.chromium.org/23526028/diff/86001/content/content_tests.gypi
File content/content_tests.gypi (right):

https://codereview.chromium.org/23526028/diff/86001/content/content_tests.gyp...
content/content_tests.gypi:171:
'../webkit/tools/test_shell/resources/missingImage.gif',
Sorry, I missed the png/gif difference on this file; I thought these two arrays
were identical, which is why I suggested a variable to remove the duplication.
Since they aren't this doesn't help, so the old structure was better.

https://codereview.chromium.org/23526028/diff/86001/content/content_tests.gyp...
content/content_tests.gypi:204: 'destination':
'<(PRODUCT_DIR)/DumpRenderTree_resources',
!ios includes Mac; now you're doing this twice on Mac. I think you probably want
to just move the whole if/else conditions block into the !ios section, so it
stays as an if/else for clarity.

[tfarina, 2013-09-13 03:18:01]

https://codereview.chromium.org/23526028/diff/86001/content/content_tests.gypi
File content/content_tests.gypi (right):

https://codereview.chromium.org/23526028/diff/86001/content/content_tests.gyp...
content/content_tests.gypi:171:
'../webkit/tools/test_shell/resources/missingImage.gif',
On 2013/09/13 00:15:55, stuartmorgan wrote:
> Sorry, I missed the png/gif difference on this file; I thought these two
arrays
> were identical, which is why I suggested a variable to remove the duplication.
> Since they aren't this doesn't help, so the old structure was better.

Done.

https://codereview.chromium.org/23526028/diff/86001/content/content_tests.gyp...
content/content_tests.gypi:204: 'destination':
'<(PRODUCT_DIR)/DumpRenderTree_resources',
On 2013/09/13 00:15:55, stuartmorgan wrote:
> !ios includes Mac; now you're doing this twice on Mac. I think you probably
want
> to just move the whole if/else conditions block into the !ios section, so it
> stays as an if/else for clarity.

Done.

[stuartmorgan, 2013-09-13 18:22:59]

The gypi LGTM now

[commit-bot: I haz the power, 2013-09-13 22:26:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/23526028/96001

[commit-bot: I haz the power, 2013-09-14 01:24:48]

Change committed as 223201