Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2352573003: Use MockSdk.getLinkedBundle(), and implement it using SummaryBuilder. (Closed)

Created:
4 years, 3 months ago by scheglov
Modified:
4 years, 3 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use MockSdk.getLinkedBundle(), and implement it using SummaryBuilder. This is a step to removing generating summaries from elements, as we decided last week. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/8010f3ac994d8ad3a95c4d105ad9ce284cdb4234

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -39 lines) Patch
M pkg/analyzer/test/src/context/mock_sdk.dart View 3 chunks +7 lines, -11 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_ast_test.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 3 chunks +8 lines, -22 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 3 months ago (2016-09-19 19:52:37 UTC) #1
Paul Berry
lgtm
4 years, 3 months ago (2016-09-19 19:56:55 UTC) #2
scheglov
4 years, 3 months ago (2016-09-19 19:58:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8010f3ac994d8ad3a95c4d105ad9ce284cdb4234 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698