[Autofill] Migrate ChromePasswordManagerClient<-->PasswordGenerationAgent IPCs to mojo.

chrome/renderer/autofill/password_autofill_agent_browsertest.cc

Index: chrome/renderer/autofill/password_autofill_agent_browsertest.cc
diff --git a/chrome/renderer/autofill/password_autofill_agent_browsertest.cc b/chrome/renderer/autofill/password_autofill_agent_browsertest.cc
index f375f0e95b1f8cca3b9b3bdcabb7a2264d407e60..6665a95d53d5ba68d57b716ef4376f01bca9fb47 100644
--- a/chrome/renderer/autofill/password_autofill_agent_browsertest.cc
+++ b/chrome/renderer/autofill/password_autofill_agent_browsertest.cc
@@ -8,9 +8,9 @@
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/renderer/autofill/fake_content_password_manager_driver.h"
+#include "chrome/renderer/autofill/fake_password_manager_client.h"
 #include "chrome/renderer/autofill/password_generation_test_utils.h"
 #include "chrome/test/base/chrome_render_view_test.h"
-#include "components/autofill/content/common/autofill_messages.h"
 #include "components/autofill/content/renderer/autofill_agent.h"
 #include "components/autofill/content/renderer/form_autofill_util.h"
 #include "components/autofill/content/renderer/password_autofill_agent.h"
@@ -22,6 +22,7 @@
 #include <components/autofill/core/common/password_form.h>
 #include "components/autofill/core/common/password_form_field_prediction_map.h"
 #include "components/password_manager/core/common/password_manager_features.h"
+#include "content/public/common/associated_interface_provider.h"
 #include "content/public/renderer/render_frame.h"
 #include "content/public/renderer/render_view.h"
 #include "services/shell/public/cpp/interface_provider.h"
@@ -333,6 +334,17 @@ class PasswordAutofillAgentTest : public ChromeRenderViewTest {
         mojom::PasswordManagerDriver::Name_,
         base::Bind(&PasswordAutofillAgentTest::BindPasswordManagerDriver,
                    base::Unretained(this)));
+
+    // We only use the fake password client for main frame
+    // because our test cases only involve the main frame.
+    content::AssociatedInterfaceProvider* remote_associated_interfaces =
+        view_->GetMainRenderFrame()->GetRemoteAssociatedInterfaces();
+    content::AssociatedInterfaceProvider::TestApi test_api_associated(
+        remote_associated_interfaces);
+    test_api_associated.SetBinderForName(
+        mojom::PasswordManagerClient::Name_,
+        base::Bind(&PasswordAutofillAgentTest::BindPasswordManagerClient,
+                   base::Unretained(this)));
   }
 
   void SetFillOnAccountSelect() {
@@ -535,12 +547,24 @@ class PasswordAutofillAgentTest : public ChromeRenderViewTest {
     EXPECT_EQ(ASCIIToUTF16(new_password_value), form.new_password_value);
   }
 
+  bool GetCalledShowPasswordGenerationPopup() {
+    base::RunLoop().RunUntilIdle();

[Ken Rockot(use gerrit already), 2016/09/20 18:26:19]

RunUntilIdle() is generally a red flag for flaky behavior. Please don't use it
unless you have to.

In this case, you could add something like a
set_show_password_generation_callback to the fake impl, and pass a RunLoop's
QuitClosure() in for that. Then you just run the RunLoop, and if the test is
functioning properly the loop will exit once ShowPasswordGeneration is called.

[yzshen1, 2016/09/20 18:50:25]

+1 for what Ken said.
Besides, you might also find the FlushForTesting() method useful. This method is
defined on [Associated]InterfacePtr/Binding. It sends a control message and
waits for a response, so when you receive the response, you can be sure that any
message sent prior to the control message have been received by the other side.

[leonhsl(Using Gerrit), 2016/09/21 11:46:57]

OK.. Thanks! I had no idea of FlushForTesting() before, change to use it,
because for some test cases maybe there has no any ShowPasswordGenerationPopup
request. 
Also, I found the root cause for the failure here and I've changed
AssociatedInterfaceProvider::LocalProvider implementation, now this test case
PASS.

+    return fake_pw_client_.called_show_pw_generation_popup();
+  }
+
   void BindPasswordManagerDriver(mojo::ScopedMessagePipeHandle handle) {
     fake_driver_.BindRequest(
         mojo::MakeRequest<mojom::PasswordManagerDriver>(std::move(handle)));
   }
 
+  void BindPasswordManagerClient(mojo::ScopedInterfaceEndpointHandle handle) {
+    fake_pw_client_.BindRequest(
+        mojo::MakeAssociatedRequest<mojom::PasswordManagerClient>(
+            std::move(handle)));
+  }
+
   FakeContentPasswordManagerDriver fake_driver_;
+  FakePasswordManagerClient fake_pw_client_;
 
   base::string16 username1_;
   base::string16 username2_;
@@ -1983,8 +2007,7 @@ TEST_F(PasswordAutofillAgentTest, PasswordGenerationSupersedesAutofill) {
   SetFocused(password_element_);
   SimulateElementClick("new_password");
   EXPECT_FALSE(GetCalledShowPasswordSuggestions());
-  EXPECT_TRUE(render_thread_->sink().GetFirstMessageMatching(
-      AutofillHostMsg_ShowPasswordGenerationPopup::ID));
+  EXPECT_TRUE(GetCalledShowPasswordGenerationPopup());
 }
 
 // Tests that a password change form is properly filled with the username and