Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Unified Diff: components/autofill/content/renderer/password_generation_agent.cc

Issue 2352533003: [Autofill] Migrate ChromePasswordManagerClient<-->PasswordGenerationAgent IPCs to mojo. (Closed)
Patch Set: Rebase only Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/password_generation_agent.cc
diff --git a/components/autofill/content/renderer/password_generation_agent.cc b/components/autofill/content/renderer/password_generation_agent.cc
index bc36e3d01426fbdbbc3c2d195030adf62415d4c3..d5371f679ced0d38a981b40c10fb6c17e1dc6a3e 100644
--- a/components/autofill/content/renderer/password_generation_agent.cc
+++ b/components/autofill/content/renderer/password_generation_agent.cc
@@ -8,7 +8,6 @@
#include "base/command_line.h"
#include "base/logging.h"
-#include "components/autofill/content/common/autofill_messages.h"
#include "components/autofill/content/renderer/form_autofill_util.h"
#include "components/autofill/content/renderer/form_classifier.h"
#include "components/autofill/content/renderer/password_autofill_agent.h"
@@ -19,6 +18,7 @@
#include "components/autofill/core/common/password_form_generation_data.h"
#include "components/autofill/core/common/password_generation_util.h"
#include "components/autofill/core/common/signatures_util.h"
+#include "content/public/common/associated_interface_provider.h"
#include "content/public/renderer/render_frame.h"
#include "content/public/renderer/render_view.h"
#include "google_apis/gaia/gaia_urls.h"
@@ -418,9 +418,8 @@ void PasswordGenerationAgent::DetermineGenerationElement() {
password_generation::LogPasswordGenerationEvent(
password_generation::GENERATION_AVAILABLE);
possible_account_creation_forms_.clear();
- Send(new AutofillHostMsg_GenerationAvailableForForm(
- routing_id(),
- *generation_form_data_->form));
+ GetPasswordManagerClient()->GenerationAvailableForForm(
+ *generation_form_data_->form);
return;
}
}
@@ -512,30 +511,26 @@ bool PasswordGenerationAgent::TextDidChangeInTextField(
void PasswordGenerationAgent::ShowGenerationPopup() {
if (!render_frame())
return;
- Send(new AutofillHostMsg_ShowPasswordGenerationPopup(
- routing_id(),
+ GetPasswordManagerClient()->ShowPasswordGenerationPopup(
render_frame()->GetRenderView()->ElementBoundsInWindow(
generation_element_),
- generation_element_.maxLength(),
- generation_element_.nameForAutofill(),
- is_manually_triggered_,
- *generation_form_data_->form));
+ generation_element_.maxLength(), generation_element_.nameForAutofill(),
+ is_manually_triggered_, *generation_form_data_->form);
generation_popup_shown_ = true;
}
void PasswordGenerationAgent::ShowEditingPopup() {
if (!render_frame())
return;
- Send(new AutofillHostMsg_ShowPasswordEditingPopup(
- routing_id(),
- render_frame()->GetRenderView()->ElementBoundsInWindow(
- generation_element_),
- *generation_form_data_->form));
+ GetPasswordManagerClient()->ShowPasswordEditingPopup(
+ render_frame()->GetRenderView()->ElementBoundsInWindow(
+ generation_element_),
+ *generation_form_data_->form);
editing_popup_shown_ = true;
}
void PasswordGenerationAgent::HidePopup() {
- Send(new AutofillHostMsg_HidePasswordGenerationPopup(routing_id()));
+ GetPasswordManagerClient()->HidePasswordGenerationPopup();
}
void PasswordGenerationAgent::UserTriggeredGeneratePassword() {
@@ -582,4 +577,14 @@ PasswordGenerationAgent::GetPasswordManagerDriver() {
return password_agent_->GetPasswordManagerDriver();
}
+const mojom::PasswordManagerClientAssociatedPtr&
+PasswordGenerationAgent::GetPasswordManagerClient() {
+ if (!password_manager_client_) {
+ render_frame()->GetRemoteAssociatedInterfaces()->GetInterface(
+ &password_manager_client_);
+ }
+
+ return password_manager_client_;
+}
+
} // namespace autofill
« no previous file with comments | « components/autofill/content/renderer/password_generation_agent.h ('k') | components/password_manager/content/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698