Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: components/autofill/content/public/interfaces/autofill_driver.mojom

Issue 2352533003: [Autofill] Migrate ChromePasswordManagerClient<-->PasswordGenerationAgent IPCs to mojo. (Closed)
Patch Set: Fix browser_tests Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/public/interfaces/autofill_driver.mojom
diff --git a/components/autofill/content/public/interfaces/autofill_driver.mojom b/components/autofill/content/public/interfaces/autofill_driver.mojom
index 9ce701d72daf97501d600d811720c4d994127ea4..53c8a63e897da4d89c74687aab42909c3fd17b1a 100644
--- a/components/autofill/content/public/interfaces/autofill_driver.mojom
+++ b/components/autofill/content/public/interfaces/autofill_driver.mojom
@@ -110,3 +110,27 @@ interface PasswordManagerDriver {
SaveGenerationFieldDetectedByClassifier(
PasswordForm password_form, mojo.common.mojom.String16 generation_field);
};
+
+// There is one instance of this interface per web contents in the browser
+// process.
+interface PasswordManagerClient {
+ // Instructs the browser that generation is available for this particular
+ // form. This is used for UMA stats.
+ GenerationAvailableForForm(PasswordForm password_form);
+
+ // Instructs the browser to show the password generation popup at the
+ // specified location. This location should be specified in the renderers
+ // coordinate system. Form is the form associated with the password field.
+ ShowPasswordGenerationPopup(
+ gfx.mojom.RectF bounds, int32 max_length,
vabr (Chromium) 2016/09/27 15:06:12 nit: |max_length| and other arguments are missing
leonhsl(Using Gerrit) 2016/09/28 02:40:39 Done.
+ mojo.common.mojom.String16 generation_element, bool is_manually_triggered,
+ PasswordForm password_form);
+
+ // Instructs the browser to show the popup for editing a generated password.
+ // The location should be specified in the renderers coordinate system. Form
+ // is the form associated with the password field.
+ ShowPasswordEditingPopup(gfx.mojom.RectF bounds, PasswordForm password_form);
+
+ // Instructs the browser to hide any password generation popups.
+ HidePasswordGenerationPopup();
+};

Powered by Google App Engine
This is Rietveld 408576698