components/autofill/content/common/autofill_message_generator.h - Issue 2352533003: [Autofill] Migrate ChromePasswordManagerClient<-->PasswordGenerationAgent IPCs to mojo.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/autofill/content/common/autofill_message_generator.h

Issue 2352533003: [Autofill] Migrate ChromePasswordManagerClient<-->PasswordGenerationAgent IPCs to mojo. (Closed)

Patch Set: Address comments from Vaclav Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « components/autofill/content/common/OWNERS ('k') | components/autofill/content/common/autofill_messages.h » ('j') | content/common/associated_interface_provider_impl.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Multiply-included file, hence no include guard.	5 // Multiply-included file, hence no include guard.

6	6

7 #include "components/autofill/content/common/autofill_messages.h"	7 #include "components/autofill/content/common/autofill_param_traits_macros.h"

	8 #include "components/autofill/core/common/form_field_data.h"

	9 #include "ipc/ipc_message_macros.h"

	10 #include "ipc/ipc_message_utils.h"

	11

	12 IPC_ENUM_TRAITS_MAX_VALUE(autofill::FormFieldData::CheckStatus,
	Tom Sepez 2016/09/28 16:38:25 It feels like these definitions all belong in comp It feels like these definitions all belong in components/autofill/content/common/autofill_param_traits_macros.h now that there are no messages being defined, just traits. leonhsl(Using Gerrit) 2016/10/07 09:42:52 Yeah there are only the traits now, which are stil Show quoted text On 2016/09/28 16:38:25, Tom Sepez wrote: > It feels like these definitions all belong in > components/autofill/content/common/autofill_param_traits_macros.h now that there > are no messages being defined, just traits. Yeah there are only the traits now, which are still used by the IPC message at https://cs.chromium.org/chromium/src/chrome/common/importer/profile_import_pr... Moved all contents of autofill_message_generator.h into autofill_param_traits_macros.h, and deleted autofill_message_generator.h itself.
	13 autofill::FormFieldData::CheckStatus::CHECKED)

	14

	15 IPC_ENUM_TRAITS_MAX_VALUE(autofill::FormFieldData::RoleAttribute,

	16 autofill::FormFieldData::ROLE_ATTRIBUTE_OTHER)

	17

	18 IPC_ENUM_TRAITS_MAX_VALUE(base::i18n::TextDirection,

	19 base::i18n::TEXT_DIRECTION_NUM_DIRECTIONS - 1)

	20

	21 IPC_STRUCT_TRAITS_BEGIN(autofill::FormFieldData)

	22 IPC_STRUCT_TRAITS_MEMBER(label)

	23 IPC_STRUCT_TRAITS_MEMBER(name)

	24 IPC_STRUCT_TRAITS_MEMBER(value)

	25 IPC_STRUCT_TRAITS_MEMBER(form_control_type)

	26 IPC_STRUCT_TRAITS_MEMBER(autocomplete_attribute)

	27 IPC_STRUCT_TRAITS_MEMBER(placeholder)

	28 IPC_STRUCT_TRAITS_MEMBER(role)

	29 IPC_STRUCT_TRAITS_MEMBER(max_length)

	30 IPC_STRUCT_TRAITS_MEMBER(is_autofilled)

	31 IPC_STRUCT_TRAITS_MEMBER(check_status)

	32 IPC_STRUCT_TRAITS_MEMBER(is_focusable)

	33 IPC_STRUCT_TRAITS_MEMBER(should_autocomplete)

	34 IPC_STRUCT_TRAITS_MEMBER(text_direction)

	35 IPC_STRUCT_TRAITS_MEMBER(option_values)

	36 IPC_STRUCT_TRAITS_MEMBER(option_contents)

	37 IPC_STRUCT_TRAITS_MEMBER(css_classes)

	38 IPC_STRUCT_TRAITS_MEMBER(properties_mask)

	39 IPC_STRUCT_TRAITS_END()

OLD	NEW