components/autofill/content/common/autofill_message_generator.h - Issue 2352533003: [Autofill] Migrate ChromePasswordManagerClient<-->PasswordGenerationAgent IPCs to mojo.

Side by Side Diff: components/autofill/content/common/autofill_message_generator.h

Issue 2352533003: [Autofill] Migrate ChromePasswordManagerClient<-->PasswordGenerationAgent IPCs to mojo. (Closed)

Patch Set: Fix browser_tests Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« chrome/renderer/autofill/password_autofill_agent_browsertest.cc ('K') | « components/autofill/content/common/OWNERS ('k') | components/autofill/content/common/autofill_messages.h » ('j') | components/autofill/content/public/interfaces/autofill_driver.mojom » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.
	vabr (Chromium) 2016/09/27 15:06:11 Is this file still used? Where? Could we delete it Is this file still used? Where? Could we delete it instead? leonhsl(Using Gerrit) 2016/09/28 02:40:39 Yeah, it's still in use, we can delete all autofil Show quoted text On 2016/09/27 15:06:11, vabr (Chromium) wrote: > Is this file still used? Where? Could we delete it instead? Yeah, it's still in use, we can delete all autofill legacy IPC traits here after chrome/common/importer/profile_import_process_messages.h is converted to Mojo interface. https://cs.chromium.org/chromium/src/chrome/common/importer/profile_import_pr... still needs the IPC struct traits for autofill::PasswordForm, which then needs the struct traits of autofill::FormFieldData defined here. vabr (Chromium) 2016/09/28 08:59:55 Acknowledged. Show quoted text On 2016/09/28 02:40:39, leonhsl (OOO 29.Sep--05.Oct) wrote: > On 2016/09/27 15:06:11, vabr (Chromium) wrote: > > Is this file still used? Where? Could we delete it instead? > > Yeah, it's still in use, we can delete all autofill legacy IPC traits here after > chrome/common/importer/profile_import_process_messages.h is converted to Mojo > interface. > https://cs.chromium.org/chromium/src/chrome/common/importer/profile_import_pr... > still needs the IPC struct traits for autofill::PasswordForm, which then needs > the struct traits of autofill::FormFieldData defined here. Acknowledged.
2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Multiply-included file, hence no include guard.	5 // Multiply-included file, hence no include guard.

6	6

7 #include "components/autofill/content/common/autofill_messages.h"	7 #include "components/autofill/content/common/autofill_param_traits_macros.h"

	8 #include "components/autofill/core/common/form_field_data.h"

	9 #include "ipc/ipc_message_macros.h"

	10 #include "ipc/ipc_message_utils.h"

	11

	12 IPC_ENUM_TRAITS_MAX_VALUE(autofill::FormFieldData::CheckStatus,

	13 autofill::FormFieldData::CheckStatus::CHECKED)

	14

	15 IPC_ENUM_TRAITS_MAX_VALUE(autofill::FormFieldData::RoleAttribute,

	16 autofill::FormFieldData::ROLE_ATTRIBUTE_OTHER)

	17

	18 IPC_ENUM_TRAITS_MAX_VALUE(base::i18n::TextDirection,

	19 base::i18n::TEXT_DIRECTION_NUM_DIRECTIONS - 1)

	20

	21 IPC_STRUCT_TRAITS_BEGIN(autofill::FormFieldData)

	22 IPC_STRUCT_TRAITS_MEMBER(label)

	23 IPC_STRUCT_TRAITS_MEMBER(name)

	24 IPC_STRUCT_TRAITS_MEMBER(value)

	25 IPC_STRUCT_TRAITS_MEMBER(form_control_type)

	26 IPC_STRUCT_TRAITS_MEMBER(autocomplete_attribute)

	27 IPC_STRUCT_TRAITS_MEMBER(placeholder)

	28 IPC_STRUCT_TRAITS_MEMBER(role)

	29 IPC_STRUCT_TRAITS_MEMBER(max_length)

	30 IPC_STRUCT_TRAITS_MEMBER(is_autofilled)

	31 IPC_STRUCT_TRAITS_MEMBER(check_status)

	32 IPC_STRUCT_TRAITS_MEMBER(is_focusable)

	33 IPC_STRUCT_TRAITS_MEMBER(should_autocomplete)

	34 IPC_STRUCT_TRAITS_MEMBER(text_direction)

	35 IPC_STRUCT_TRAITS_MEMBER(option_values)

	36 IPC_STRUCT_TRAITS_MEMBER(option_contents)

	37 IPC_STRUCT_TRAITS_MEMBER(css_classes)

	38 IPC_STRUCT_TRAITS_MEMBER(properties_mask)

	39 IPC_STRUCT_TRAITS_END()

OLD	NEW