[Autofill] Migrate ChromePasswordManagerClient<-->PasswordGenerationAgent IPCs to mojo.

chrome/browser/password_manager/chrome_password_manager_client.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_
 #define CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_
 
 #include <memory>
 #include <vector>
 
 #include "base/compiler_specific.h"
 #include "base/macros.h"
 #include "base/memory/scoped_vector.h"
+#include "components/autofill/content/public/interfaces/autofill_driver.mojom.h"
 #include "components/password_manager/content/browser/content_password_manager_driver_factory.h"
 #include "components/password_manager/content/browser/credential_manager_impl.h"
 #include "components/password_manager/core/browser/password_manager.h"
 #include "components/password_manager/core/browser/password_manager_client.h"
 #include "components/password_manager/sync/browser/sync_credentials_filter.h"
 #include "components/prefs/pref_member.h"
+#include "content/public/browser/web_contents_binding_set.h"
 #include "content/public/browser/web_contents_observer.h"
 #include "content/public/browser/web_contents_user_data.h"
 #include "ui/gfx/geometry/rect.h"
 
 class Profile;
 
 namespace autofill {
 class PasswordGenerationPopupObserver;
 class PasswordGenerationPopupControllerImpl;
 }
 
 namespace content {
 class WebContents;
 }
 
 namespace password_manager {
 struct CredentialInfo;
 class PasswordGenerationManager;
 class PasswordManagerDriver;
 }
 
 // ChromePasswordManagerClient implements the PasswordManagerClient interface.
 class ChromePasswordManagerClient
     : public password_manager::PasswordManagerClient,
       public content::WebContentsObserver,
-      public content::WebContentsUserData<ChromePasswordManagerClient> {
+      public content::WebContentsUserData<ChromePasswordManagerClient>,
+      public autofill::mojom::PasswordManagerClient {
  public:
   ~ChromePasswordManagerClient() override;
 
   // PasswordManagerClient implementation.
   bool IsAutomaticPasswordSavingEnabled() const override;
   bool IsSavingAndFillingEnabledForCurrentPage() const override;
   bool IsFillingEnabledForCurrentPage() const override;
   bool PromptUserToSaveOrUpdatePassword(
       std::unique_ptr<password_manager::PasswordFormManager> form_to_save,
       password_manager::CredentialSourceType type,
@@ skipping 31 matching lines @@
   const password_manager::PasswordManager* GetPasswordManager() const override;
   autofill::AutofillManager* GetAutofillManagerForMainFrame() override;
   const GURL& GetMainFrameURL() const override;
   bool IsUpdatePasswordUIEnabled() const override;
   const GURL& GetLastCommittedEntryURL() const override;
   void AnnotateNavigationEntry(bool has_password_field) override;
   const password_manager::CredentialsFilter* GetStoreResultFilter()
       const override;
   const password_manager::LogManager* GetLogManager() const override;
 
+  // autofill::mojom::PasswordManagerClient overrides.
+  // Causes the password generation UI to be shown for the specified form.

[vabr (Chromium), 2016/09/27 15:06:11]

nit: Please move these comments to interface PasswordManagerClient instead.
Overridden interface methods do not usually have comments, because the interface
specifies the purpose of the method and the meaning of the arguments.

[leonhsl(Using Gerrit), 2016/09/28 02:40:39]

Done. Moved these comments to interface definition in autofill_driver.mojom, and
removed some redundant comments.

+  // The popup will be anchored at |bounds|. The generated password
+  // will be no longer than |max_length|. |generation_element| should contain a
+  // name of a password field at which generation popup is attached.
+  // |is_manually_triggered| informs whether it is automatically or manually
+  // triggered generation.
+  void ShowPasswordGenerationPopup(const gfx::RectF& bounds,
+                                   int max_length,
+                                   const base::string16& generation_element,
+                                   bool is_manually_triggered,
+                                   const autofill::PasswordForm& form) override;
+  // Causes the password editing UI to be shown anchored at |bounds|.
+  void ShowPasswordEditingPopup(const gfx::RectF& bounds,
+                                const autofill::PasswordForm& form) override;
+  // Notify the PasswordManager that generation is available for |form|. Used
+  // for UMA stats.
+  void GenerationAvailableForForm(const autofill::PasswordForm& form) override;
   // Hides any visible generation UI.
-  void HidePasswordGenerationPopup();
+  void HidePasswordGenerationPopup() override;
 
   static void CreateForWebContentsWithAutofillClient(
       content::WebContents* contents,
       autofill::AutofillClient* autofill_client);
 
   // Observer for PasswordGenerationPopup events. Used for testing.
   void SetTestObserver(autofill::PasswordGenerationPopupObserver* observer);
 
   static void BindCredentialManager(
       content::RenderFrameHost* render_frame_host,
       password_manager::mojom::CredentialManagerRequest request);
 
  protected:
   // Callable for tests.
   ChromePasswordManagerClient(content::WebContents* web_contents,
                               autofill::AutofillClient* autofill_client);
 
  private:
   friend class content::WebContentsUserData<ChromePasswordManagerClient>;
 
   // content::WebContentsObserver overrides.
-  bool OnMessageReceived(const IPC::Message& message,
-                         content::RenderFrameHost* render_frame_host) override;
   void DidStartNavigation(
       content::NavigationHandle* navigation_handle) override;
 
   // Given |bounds| in the renderers coordinate system, return the same bounds
   // in the screens coordinate system.
   gfx::RectF GetBoundsInScreenSpace(const gfx::RectF& bounds);
 
   // Checks if the current page fulfils the conditions for the password manager
   // to be active on it, for example Sync credentials are not saved or auto
   // filled.
   bool IsPasswordManagementEnabledForCurrentPage() const;
 
-  // Causes the password generation UI to be shown for the specified form.
-  // The popup will be anchored at |element_bounds|. The generated password
-  // will be no longer than |max_length|. |generation_element| should contain a
-  // name of a password field at which generation popup is attached.
-  // |is_manually_triggered| informs whether it is automatically or manually
-  // triggered generation.
-  void ShowPasswordGenerationPopup(content::RenderFrameHost* render_frame_host,
-                                   const gfx::RectF& bounds,
-                                   int max_length,
-                                   const base::string16& generation_element,
-                                   bool is_manually_triggered,
-                                   const autofill::PasswordForm& form);
-
-  // Causes the password editing UI to be shown anchored at |element_bounds|.
-  void ShowPasswordEditingPopup(content::RenderFrameHost* render_frame_host,
-                                const gfx::RectF& bounds,
-                                const autofill::PasswordForm& form);
-
   // Shows the dialog where the user can accept or decline the global autosignin
   // setting as a first run experience. The dialog won't appear in Incognito or
   // when the autosign-in is off.
   void PromptUserToEnableAutosigninIfNecessary();
 
-  // Notify the PasswordManager that generation is available for |form|. Used
-  // for UMA stats.
-  void GenerationAvailableForForm(const autofill::PasswordForm& form);
-
   // Called as a response to PromptUserToChooseCredentials. nullptr in |form|
   // means that nothing was chosen. |one_local_credential| is true if there was
   // just one local credential to be chosen from.
   void OnCredentialsChosen(const CredentialsCallback& callback,
                            bool one_local_credential,
                            const autofill::PasswordForm* form);
 
   // Returns true if this profile has metrics reporting and active sync
   // without custom sync passphrase.
   static bool ShouldAnnotateNavigationEntries(Profile* profile);
 
   Profile* const profile_;
 
   password_manager::PasswordManager password_manager_;
 
   password_manager::ContentPasswordManagerDriverFactory* driver_factory_;
 
   // As a mojo service, will be registered into service registry
   // of the main frame host by ChromeContentBrowserClient
   // once main frame host was created.
   password_manager::CredentialManagerImpl credential_manager_impl_;
 
+  content::WebContentsFrameBindingSet<autofill::mojom::PasswordManagerClient>
+      password_manager_client_bindings_;
+
   // Observer for password generation popup.
   autofill::PasswordGenerationPopupObserver* observer_;
 
   // Controls the popup
   base::WeakPtr<
     autofill::PasswordGenerationPopupControllerImpl> popup_controller_;
 
   // Set to false to disable password saving (will no longer ask if you
   // want to save passwords and also won't fill the passwords).
   BooleanPrefMember saving_and_filling_passwords_enabled_;
 
   const password_manager::SyncCredentialsFilter credentials_filter_;
 
   std::unique_ptr<password_manager::LogManager> log_manager_;
 
   // Set during 'NotifyUserCouldBeAutoSignedIn' in order to store the
   // form for potential use during 'NotifySuccessfulLoginWithExistingPassword'.
   std::unique_ptr<autofill::PasswordForm> possible_auto_sign_in_;
 
   DISALLOW_COPY_AND_ASSIGN(ChromePasswordManagerClient);
 };
 
 #endif  // CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_