PaymentRequest: Deprecate careOf attribute in PaymentAddress.

PaymentRequest: Deprecate careOf attribute in PaymentAddress.

Intent to deprecated:
  https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/WhUAKyc0O80

Related spec change:
  https://github.com/w3c/browser-payment-api/issues/244

BUG=648049
Committed: https://crrev.com/16b6ac0d52e6a8eca2a00eef0f5cdd4bf95befa7
Cr-Commit-Position: refs/heads/master@{#420673}

[zino, 2016-09-18 06:32:21]

Description was changed from

==========
PaymentRequest: Remove careOf attribute in PaymentAddress.

Remove 'careOf' attribute in PaymentAddress.

Related spec change:
 - https://github.com/w3c/browser-payment-api/issues/244

Intent to deprecated and remove:
 - link

BUG=xxxxxx
==========

to

==========
PaymentRequest: Remove careOf attribute in PaymentAddress.

Remove 'careOf' attribute in PaymentAddress.

Related spec change:
 - https://github.com/w3c/browser-payment-api/issues/244

Intent to deprecated and remove:
 - link

BUG=xxxxxx
==========

[zino, 2016-09-18 14:05:29]

jinho.bang@samsung.com changed reviewers:
+ rouslan@chromium.org

[zino, 2016-09-18 14:06:29]

Description was changed from

==========
PaymentRequest: Remove careOf attribute in PaymentAddress.

Remove 'careOf' attribute in PaymentAddress.

Related spec change:
 - https://github.com/w3c/browser-payment-api/issues/244

Intent to deprecated and remove:
 - link

BUG=xxxxxx
==========

to

==========
PaymentRequest: Remove careOf attribute in PaymentAddress.

Remove 'careOf' attribute in PaymentAddress.

Related spec change:
 - https://github.com/w3c/browser-payment-api/issues/244

Intent to deprecated and remove:

BUG=648049
==========

[zino, 2016-09-18 14:09:32]

Description was changed from

==========
PaymentRequest: Remove careOf attribute in PaymentAddress.

Remove 'careOf' attribute in PaymentAddress.

Related spec change:
 - https://github.com/w3c/browser-payment-api/issues/244

Intent to deprecated and remove:

BUG=648049
==========

to

==========
PaymentRequest: Remove careOf attribute in PaymentAddress.

Remove 'careOf' attribute in PaymentAddress.

Related spec change:
  https://github.com/w3c/browser-payment-api/issues/244

Intent to deprecated and remove:
  https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/WhUAKyc0O80

BUG=648049
==========

[zino, 2016-09-18 14:13:11]

PTAL.

I've just sent to intent to deprecated and remove to blink-dev.

[please use gerrit instead, 2016-09-20 11:49:25]

The resolution in
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/WhUAKyc0O80 was
to mark "careOf" deprecated for now and remove it in M-56. Can you investigate
how to do this?

In the meantime, you can proceed with this patch by keeping "careOf" in Blink,
but make it always an empty string.

There was also a request to add a UseCounter to "careOf". Let me know if you
need help with this.

Thank you for helping out!!!

[zino, 2016-09-20 15:52:23]

On 2016/09/20 11:49:25, rouslan (slow) wrote:
> The resolution in
> https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/WhUAKyc0O80
was
> to mark "careOf" deprecated for now and remove it in M-56. Can you investigate
> how to do this?
> 
> In the meantime, you can proceed with this patch by keeping "careOf" in Blink,
> but make it always an empty string.
> 
> There was also a request to add a UseCounter to "careOf". Let me know if you
> need help with this.
> 
> Thank you for helping out!!!

Sure :) Thanks!

I'll upload a new patch set soon.

[zino, 2016-09-21 19:06:42]

Description was changed from

==========
PaymentRequest: Remove careOf attribute in PaymentAddress.

Remove 'careOf' attribute in PaymentAddress.

Related spec change:
  https://github.com/w3c/browser-payment-api/issues/244

Intent to deprecated and remove:
  https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/WhUAKyc0O80

BUG=648049
==========

to

==========
PaymentRequest: Deprecate careOf attribute in PaymentAddress.

Intent to deprecated:
  https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/WhUAKyc0O80

Related spec change:
  https://github.com/w3c/browser-payment-api/issues/244

BUG=648049
==========

[zino, 2016-09-21 19:08:59]

jinho.bang@samsung.com changed reviewers:
+ dfalcantara@chromium.org, jdonnelly@chromium.org, mkwst@chromium.org

[zino, 2016-09-21 19:11:14]

jinho.bang@samsung.com changed reviewers:
- dfalcantara@chromium.org, jdonnelly@chromium.org, mkwst@chromium.org

[zino, 2016-09-21 19:22:14]

jinho.bang@samsung.com changed reviewers:
+ haraken@chromium.org, jdonnelly@chromium.org, mpearson@google.com,
rsesek@chromium.org

[zino, 2016-09-21 19:22:14]

rouslan@ for payment/autofill
jdonnelly@ for ios/*
haraken@ for blink/Source/core/*
mpearson@ for histograms.xml
rsesek@ for payment_request.mojom

PTAL

[Mark P, 2016-09-21 19:54:47]

mpearson@chromium.org changed reviewers:
+ mpearson@chromium.org

[Mark P, 2016-09-21 19:54:48]

histograms.xml lgtm

[Robert Sesek, 2016-09-21 20:40:00]

mojom lgtm

[Justin Donnelly, 2016-09-21 20:45:09]

ios lgtm

[haraken, 2016-09-22 00:54:42]

LGTM

https://codereview.chromium.org/2352513002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/Deprecation.cpp (right):

https://codereview.chromium.org/2352513002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/Deprecation.cpp:389: return
willBeRemoved("PaymentAddress.careOf", 56, "5728579069411328");

Maybe add a comment about what the value implies.

[please use gerrit instead, 2016-09-22 13:22:37]

https://codereview.chromium.org/2352513002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/Deprecation.cpp (right):

https://codereview.chromium.org/2352513002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/Deprecation.cpp:389: return
willBeRemoved("PaymentAddress.careOf", 56, "5728579069411328");
On 2016/09/22 00:54:42, haraken wrote:
> 
> Maybe add a comment about what the value implies.

+1

https://codereview.chromium.org/2352513002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/payments/PaymentAddress.h (right):

https://codereview.chromium.org/2352513002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/payments/PaymentAddress.h:19: class
ExecutionContext;
What is the reason for this declaration?

[zino, 2016-09-22 15:40:21]

jinho.bang@samsung.com changed reviewers:
+ tedchoc@chromium.org

[zino, 2016-09-22 15:42:30]

+ Ted C for chrome/android/junit/*

I uploaded a new patchset.

PTAL.

https://codereview.chromium.org/2352513002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/Deprecation.cpp (right):

https://codereview.chromium.org/2352513002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/Deprecation.cpp:389: return
willBeRemoved("PaymentAddress.careOf", 56, "5728579069411328");
On 2016/09/22 13:22:37, rouslan (slow) wrote:
> On 2016/09/22 00:54:42, haraken wrote:
> > 
> > Maybe add a comment about what the value implies.
> 
> +1

I left a comment but I'm not sure if you means that.
What do you want a comment for? (PaymentAddress.careOf? or 5728579069411328?)

Anyway, willBeRemoved("PaymentAddress.careOf", 56, "5728579069411328");
will display to console log as follows (when JS author accesses
the PaymentAddress.careOf attribute.)

"PaymentAddress.careOf is deprecated and will be removed in M56,
around January 2017. See https://www.chromestatus.com/features/5728579069411328
for more details."

https://codereview.chromium.org/2352513002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/payments/PaymentAddress.h (right):

https://codereview.chromium.org/2352513002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/payments/PaymentAddress.h:19: class
ExecutionContext;
On 2016/09/22 13:22:37, rouslan (slow) wrote:
> What is the reason for this declaration?

It's my mistake. Done.
Thanks.

[Ted C, 2016-09-22 17:01:24]

On 2016/09/22 15:42:30, zino wrote:
> + Ted C for chrome/android/junit/*

I'm adding rouslan to owners for the junit payments folder, so you
"shouldn't" need me.

And a more fundamental level, this seems like we are in fact removing
this feature and not deprecating it.  I would have expected the flow
would be:
1.) Deprecate and log w/ no logic changes
2.) Use empty string but nothing bad happens
3.) Remove completely and "maybe" bad things happen.

I don't know how this goes for in blink, but this is not what I would
have expected.  But I'll defer entirely to Rouslan here.
> 
> I uploaded a new patchset.
> 
> PTAL.
> 
>
https://codereview.chromium.org/2352513002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/frame/Deprecation.cpp (right):
> 
>
https://codereview.chromium.org/2352513002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/frame/Deprecation.cpp:389: return
> willBeRemoved("PaymentAddress.careOf", 56, "5728579069411328");
> On 2016/09/22 13:22:37, rouslan (slow) wrote:
> > On 2016/09/22 00:54:42, haraken wrote:
> > > 
> > > Maybe add a comment about what the value implies.
> > 
> > +1
> 
> I left a comment but I'm not sure if you means that.
> What do you want a comment for? (PaymentAddress.careOf? or 5728579069411328?)
> 
> Anyway, willBeRemoved("PaymentAddress.careOf", 56, "5728579069411328");
> will display to console log as follows (when JS author accesses
> the PaymentAddress.careOf attribute.)
> 
> "PaymentAddress.careOf is deprecated and will be removed in M56,
> around January 2017. See
https://www.chromestatus.com/features/5728579069411328
> for more details."
> 
>
https://codereview.chromium.org/2352513002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/modules/payments/PaymentAddress.h (right):
> 
>
https://codereview.chromium.org/2352513002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/modules/payments/PaymentAddress.h:19: class
> ExecutionContext;
> On 2016/09/22 13:22:37, rouslan (slow) wrote:
> > What is the reason for this declaration?
> 
> It's my mistake. Done.
> Thanks.

[please use gerrit instead, 2016-09-23 10:19:40]

On 2016/09/22 17:01:24, Ted C wrote:
> I'm adding rouslan to owners for the junit payments folder, so you
> "shouldn't" need me.

Thank you.

> And a more fundamental level, this seems like we are in fact removing
> this feature and not deprecating it.  I would have expected the flow
> would be:
> 1.) Deprecate and log w/ no logic changes
> 2.) Use empty string but nothing bad happens
> 3.) Remove completely and "maybe" bad things happen.

#2 is already the case, because Blink API had support for "careOf", but Chrome
always set it to an empty string. This patch is #1. We plan to take step #3 in
M-56.

[please use gerrit instead, 2016-09-23 10:28:36]

lgtm

[zino, 2016-09-23 11:20:42]

The CQ bit was checked by jinho.bang@samsung.com

[zino, 2016-09-23 11:20:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
mpearson@chromium.org, rsesek@chromium.org, haraken@chromium.org,
jdonnelly@chromium.org
Link to the patchset: https://codereview.chromium.org/2352513002/#ps40001
(title: "PaymentRequest: Deprecate careOf attribute in PaymentAddress.")

[commit-bot: I haz the power, 2016-09-23 11:20:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 11:30:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 11:30:55]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[zino, 2016-09-23 12:13:51]

The CQ bit was checked by jinho.bang@samsung.com

[commit-bot: I haz the power, 2016-09-23 12:13:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 12:23:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 12:23:06]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[zino, 2016-09-23 12:29:24]

On 2016/09/23 12:23:06, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Hmm, the bot doesn't seem to recognize new OWNERS file for junit/.../payments?

PTAL, Ted C?

[Ted C, 2016-09-23 17:11:37]

lgtm

[zino, 2016-09-23 17:12:49]

The CQ bit was checked by jinho.bang@samsung.com

[commit-bot: I haz the power, 2016-09-23 17:13:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 18:39:53]

Description was changed from

==========
PaymentRequest: Deprecate careOf attribute in PaymentAddress.

Intent to deprecated:
  https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/WhUAKyc0O80

Related spec change:
  https://github.com/w3c/browser-payment-api/issues/244

BUG=648049
==========

to

==========
PaymentRequest: Deprecate careOf attribute in PaymentAddress.

Intent to deprecated:
  https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/WhUAKyc0O80

Related spec change:
  https://github.com/w3c/browser-payment-api/issues/244

BUG=648049
==========

[commit-bot: I haz the power, 2016-09-23 18:39:56]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-23 18:41:48]

Description was changed from

==========
PaymentRequest: Deprecate careOf attribute in PaymentAddress.

Intent to deprecated:
  https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/WhUAKyc0O80

Related spec change:
  https://github.com/w3c/browser-payment-api/issues/244

BUG=648049
==========

to

==========
PaymentRequest: Deprecate careOf attribute in PaymentAddress.

Intent to deprecated:
  https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/WhUAKyc0O80

Related spec change:
  https://github.com/w3c/browser-payment-api/issues/244

BUG=648049

Committed: https://crrev.com/16b6ac0d52e6a8eca2a00eef0f5cdd4bf95befa7
Cr-Commit-Position: refs/heads/master@{#420673}
==========

[commit-bot: I haz the power, 2016-09-23 18:41:49]

Patchset 3 (id:??) landed as
https://crrev.com/16b6ac0d52e6a8eca2a00eef0f5cdd4bf95befa7
Cr-Commit-Position: refs/heads/master@{#420673}