Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 2352463002: ConvolverOptions.buffer should be nullable (Closed)

Created:
4 years, 3 months ago by fs
Modified:
4 years, 3 months ago
Reviewers:
foolip, Raymond Toy
CC:
blink-reviews, chromium-reviews, haraken, hongchan
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ConvolverOptions.buffer should be nullable TBR=rtoy@chromium.org,foolip@chromium.org BUG=626449, 647693 Committed: https://crrev.com/5c1f36dce5382b5461570efea3917b54e9125a0a Cr-Commit-Position: refs/heads/master@{#419388}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/modules/webaudio/ConvolverOptions.idl View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
fs
https://codereview.chromium.org/2102133002 and https://codereview.chromium.org/2342393002 appears to have collided (at least in a sense), and now the ...
4 years, 3 months ago (2016-09-17 20:19:30 UTC) #3
fs
On 2016/09/17 at 20:19:30, fs wrote: ... > ...slightly more "productive" ... Ehm, "constructive" (swedish-ism ...
4 years, 3 months ago (2016-09-17 20:21:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2352463002/1
4 years, 3 months ago (2016-09-17 22:22:06 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-17 22:25:59 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5c1f36dce5382b5461570efea3917b54e9125a0a Cr-Commit-Position: refs/heads/master@{#419388}
4 years, 3 months ago (2016-09-17 22:29:28 UTC) #11
foolip
Thanks for fixing that!
4 years, 3 months ago (2016-09-18 00:13:39 UTC) #12
Raymond Toy
On 2016/09/18 00:13:39, foolip wrote: > Thanks for fixing that! Ideally a spec update is ...
4 years, 3 months ago (2016-09-19 15:31:06 UTC) #13
Raymond Toy
On 2016/09/19 15:31:06, Raymond Toy wrote: > On 2016/09/18 00:13:39, foolip wrote: > > Thanks ...
4 years, 3 months ago (2016-09-19 15:31:55 UTC) #14
foolip
4 years, 3 months ago (2016-09-19 15:43:15 UTC) #15
Message was sent while issue was closed.
On 2016/09/19 15:31:55, Raymond Toy-OOO TPAC Sep20-24 wrote:
> On 2016/09/19 15:31:06, Raymond Toy wrote:
> > On 2016/09/18 00:13:39, foolip wrote:
> > > Thanks for fixing that!
> > 
> > Ideally a spec update is needed too. (I'll write up the issue now.)
> > 
> > A test would have been great too, but even without this
> > 
> > new ConvolverNode(context, {buffer: null})
> > 
> > is accepted.  Is this an issue with our IDL compiler?

Yes, any dictionary member of interface type was effectively nullable before
https://codereview.chromium.org/2342393002

> AudioBufferSourceOptions has the same problem:
> 
> dictionary AudioBufferSourceOptions {
>     AudioBuffer buffer;
>     float detune;
>     boolean loop;
>     double loopEnd;
>     double loopStart;
>     float playbackRate;
> };

Yeah, I see you filed https://github.com/WebAudio/web-audio-api/issues/980, I'll
comment there!

Powered by Google App Engine
This is Rietveld 408576698