ConvolverOptions.buffer should be nullable

ConvolverOptions.buffer should be nullable

TBR=rtoy@chromium.org,foolip@chromium.org
BUG=626449, 647693
Committed: https://crrev.com/5c1f36dce5382b5461570efea3917b54e9125a0a
Cr-Commit-Position: refs/heads/master@{#419388}

[fs, 2016-09-17 20:10:01]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-17 20:10:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2016-09-17 20:19:30]

https://codereview.chromium.org/2102133002 and
https://codereview.chromium.org/2342393002 appears to have collided (at least in
a sense), and now the bots are on fire...

After a glance at the spec it seemed like this was supposed to be nullable, and
that appeared to be what the tests where assuming too, so I figured this might
be slightly more "productive" than randomly reverting one of the two CLs... =)

If you disagree with this then, well, you know the drill ;-)

[fs, 2016-09-17 20:21:47]

On 2016/09/17 at 20:19:30, fs wrote:
...
> ...slightly more "productive" ...

Ehm, "constructive" (swedish-ism fail...)

[commit-bot: I haz the power, 2016-09-17 22:20:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-17 22:20:38]

Dry run: This issue passed the CQ dry run.

[fs, 2016-09-17 22:21:51]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2016-09-17 22:22:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-17 22:25:59]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-17 22:29:27]

Description was changed from

==========
ConvolverOptions.buffer should be nullable

TBR=rtoy@chromium.org,foolip@chromium.org
BUG=626449,647693
==========

to

==========
ConvolverOptions.buffer should be nullable

TBR=rtoy@chromium.org,foolip@chromium.org
BUG=626449,647693

Committed: https://crrev.com/5c1f36dce5382b5461570efea3917b54e9125a0a
Cr-Commit-Position: refs/heads/master@{#419388}
==========

[commit-bot: I haz the power, 2016-09-17 22:29:28]

Patchset 1 (id:??) landed as
https://crrev.com/5c1f36dce5382b5461570efea3917b54e9125a0a
Cr-Commit-Position: refs/heads/master@{#419388}

[foolip, 2016-09-18 00:13:39]

Thanks for fixing that!

[Raymond Toy, 2016-09-19 15:31:06]

On 2016/09/18 00:13:39, foolip wrote:
> Thanks for fixing that!

Ideally a spec update is needed too. (I'll write up the issue now.)

A test would have been great too, but even without this

new ConvolverNode(context, {buffer: null})

is accepted.  Is this an issue with our IDL compiler?

[Raymond Toy, 2016-09-19 15:31:55]

On 2016/09/19 15:31:06, Raymond Toy wrote:
> On 2016/09/18 00:13:39, foolip wrote:
> > Thanks for fixing that!
> 
> Ideally a spec update is needed too. (I'll write up the issue now.)
> 
> A test would have been great too, but even without this
> 
> new ConvolverNode(context, {buffer: null})
> 
> is accepted.  Is this an issue with our IDL compiler?

AudioBufferSourceOptions has the same problem:

dictionary AudioBufferSourceOptions {
    AudioBuffer buffer;
    float detune;
    boolean loop;
    double loopEnd;
    double loopStart;
    float playbackRate;
};

[foolip, 2016-09-19 15:43:15]

On 2016/09/19 15:31:55, Raymond Toy-OOO TPAC Sep20-24 wrote:
> On 2016/09/19 15:31:06, Raymond Toy wrote:
> > On 2016/09/18 00:13:39, foolip wrote:
> > > Thanks for fixing that!
> > 
> > Ideally a spec update is needed too. (I'll write up the issue now.)
> > 
> > A test would have been great too, but even without this
> > 
> > new ConvolverNode(context, {buffer: null})
> > 
> > is accepted.  Is this an issue with our IDL compiler?

Yes, any dictionary member of interface type was effectively nullable before
https://codereview.chromium.org/2342393002

> AudioBufferSourceOptions has the same problem:
> 
> dictionary AudioBufferSourceOptions {
>     AudioBuffer buffer;
>     float detune;
>     boolean loop;
>     double loopEnd;
>     double loopStart;
>     float playbackRate;
> };

Yeah, I see you filed https://github.com/WebAudio/web-audio-api/issues/980, I'll
comment there!