Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2352423002: [heap] Concurrently free empty typed slot set chunks. (Closed)

Created:
4 years, 3 months ago by Hannes Payer (out of office)
Modified:
4 years, 2 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Concurrently free empty typed slot set chunks. BUG=chromium:648568 Committed: https://crrev.com/ff8101d8e8d5e14dfa89de1252c510e6a0775539 Cr-Commit-Position: refs/heads/master@{#39605}

Patch Set 1 #

Patch Set 2 : format #

Patch Set 3 : Allocate top level chunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -23 lines) Patch
M src/heap/mark-compact.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/heap/remembered-set.h View 1 2 chunks +8 lines, -5 lines 0 comments Download
M src/heap/remembered-set.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/heap/slot-set.h View 1 2 6 chunks +37 lines, -1 line 0 comments Download
M test/unittests/heap/slot-set-unittest.cc View 1 1 chunk +21 lines, -16 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
ulan
lgtm!
4 years, 3 months ago (2016-09-21 14:44:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2352423002/20001
4 years, 3 months ago (2016-09-21 14:48:14 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/9102) v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 3 months ago (2016-09-21 15:01:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2352423002/40001
4 years, 3 months ago (2016-09-21 19:14:18 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-21 20:10:40 UTC) #15
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/ff8101d8e8d5e14dfa89de1252c510e6a0775539 Cr-Commit-Position: refs/heads/master@{#39605}
4 years, 3 months ago (2016-09-21 20:11:24 UTC) #17
adamk
4 years, 3 months ago (2016-09-21 23:48:28 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2358333002/ by adamk@chromium.org.

The reason for reverting is: TSAN failures on Linux64:

https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/11850

Also saw various threading-related flakiness on multiple bots..

Powered by Google App Engine
This is Rietveld 408576698