Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 2352393004: [HBD] Plumb the no-fallback placeholder click into the browser process. (Closed)

Created:
4 years, 3 months ago by tommycli
Modified:
4 years, 3 months ago
CC:
chromium-reviews, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[HBD] Plumb the no-fallback placeholder click into the browser process. BUG=641626 Committed: https://crrev.com/8447f80e0899fa4e34e9fda1310484e839bd8a13 Cr-Commit-Position: refs/heads/master@{#420649}

Patch Set 1 #

Patch Set 2 : Merge branch 'master' of https://chromium.googlesource.com/chromium/src into 284-hbd-update-placeho… #

Patch Set 3 : fix mistype #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M chrome/browser/plugins/plugin_observer.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/plugins/plugin_observer.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/common/render_messages.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/renderer/plugins/chrome_plugin_placeholder.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 20 (10 generated)
tommycli
raymes: PTAL. Once at this point (the browser process) you can trigger the prompt right? ...
4 years, 3 months ago (2016-09-21 23:20:09 UTC) #2
raymes
This seems fine to me - lgtm
4 years, 3 months ago (2016-09-22 00:33:08 UTC) #3
tommycli
tsepez: PTAL messages bauerb: PTAL plugins Thanks!
4 years, 3 months ago (2016-09-22 16:05:19 UTC) #5
Tom Sepez
lgtm
4 years, 3 months ago (2016-09-22 17:05:15 UTC) #6
Bernhard Bauer
lgtm
4 years, 3 months ago (2016-09-23 08:39:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2352393004/1
4 years, 3 months ago (2016-09-23 16:01:57 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/240721) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 3 months ago (2016-09-23 16:11:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2352393004/40001
4 years, 3 months ago (2016-09-23 17:38:17 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-23 17:44:39 UTC) #18
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 17:46:08 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8447f80e0899fa4e34e9fda1310484e839bd8a13
Cr-Commit-Position: refs/heads/master@{#420649}

Powered by Google App Engine
This is Rietveld 408576698