Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1627)

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.cc

Issue 2352353002: Add AppLauncherId wrapper for items shown in shelf (Closed)
Patch Set: Review v10 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.cc
diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.cc b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.cc
index 93064ebd064d8cd62196684789a59044c2469c1b..26d3abadaff2e8c48f065a27fdcc92d339e60823 100644
--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.cc
+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.cc
@@ -279,31 +279,36 @@ void ChromeLauncherControllerMus::PinAppsFromPrefs() {
if (!ConnectToShelfController())
return;
- std::vector<std::string> pinned_apps = ash::launcher::GetPinnedAppsFromPrefs(
- profile()->GetPrefs(), launcher_controller_helper());
+ std::vector<ash::launcher::AppLauncherId> pinned_apps =
+ ash::launcher::GetPinnedAppsFromPrefs(profile()->GetPrefs(),
+ launcher_controller_helper());
- for (const auto& app : pinned_apps) {
- if (app == ash::launcher::kPinnedAppsPlaceholder)
+ for (const auto& app_launcher_id : pinned_apps) {
+ const std::string app_launcher_id_str = app_launcher_id.ToString();
+ if (app_launcher_id_str == ash::launcher::kPinnedAppsPlaceholder)
continue;
ash::mojom::ShelfItemPtr item(ash::mojom::ShelfItem::New());
- item->app_id = app;
- item->app_title = mojo::String::From(
- launcher_controller_helper()->GetAppTitle(profile(), app));
+ item->app_id = app_launcher_id_str;
+ item->app_title =
+ mojo::String::From(launcher_controller_helper()->GetAppTitle(
+ profile(), app_launcher_id_str));
ResourceBundle& rb = ResourceBundle::GetSharedInstance();
const gfx::Image& image = rb.GetImageNamed(IDR_APP_DEFAULT_ICON);
item->image = *image.ToSkBitmap();
std::unique_ptr<ChromeShelfItemDelegate> delegate(
- new ChromeShelfItemDelegate(app, this));
+ new ChromeShelfItemDelegate(app_launcher_id_str, this));
shelf_controller()->PinItem(std::move(item),
delegate->CreateInterfacePtrInfoAndBind(
shelf_controller().associated_group()));
- app_id_to_item_delegate_.insert(std::make_pair(app, std::move(delegate)));
+ app_id_to_item_delegate_.insert(
+ std::make_pair(app_launcher_id_str, std::move(delegate)));
- AppIconLoader* app_icon_loader = GetAppIconLoaderForApp(app);
+ AppIconLoader* app_icon_loader =
+ GetAppIconLoaderForApp(app_launcher_id_str);
if (app_icon_loader) {
- app_icon_loader->FetchImage(app);
- app_icon_loader->UpdateImage(app);
+ app_icon_loader->FetchImage(app_launcher_id_str);
+ app_icon_loader->UpdateImage(app_launcher_id_str);
}
}
}
« no previous file with comments | « chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698