Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2352313002: Revert of Roll recipe dependencies (trivial). (Closed)

Created:
4 years, 3 months ago by loyso (OOO)
Modified:
4 years, 1 month ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll recipe dependencies (trivial). (patchset #1 id:1 of https://codereview.chromium.org/2353083004/ ) Reason for revert: Looks like it breaks code searh build on Linux and ChromeOS: https://build.chromium.org/p/chromium.infra.cron/builders/Chromium%20Linux%20Codesearch/builds/3018 https://build.chromium.org/p/chromium.infra.cron/builders/ChromiumOS%20Codesearch/builds/3022 Original issue's description: > Roll recipe dependencies (trivial). > > This is an automated CL created by the recipe roller. This CL rolls recipe > changes from upstream projects (e.g. depot_tools) into downstream projects > (e.g. tools/build). > > More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug > (or complain) > > build: > https://crrev.com/2c1c32b86fc93210cff0450d29df4b47055643af Add goma_dir getter to recipe_module goma (tikuta@chromium.org) > > TBR=martiniss@chromium.org,phajdan.jr@chromium.org > BUG=621828 > > Recipe-Tryjob-Bypass-Reason: Autoroller > Bugdroid-Send-Email: False > Committed: https://crrev.com/df6448ccc65c9a19257f0c2b20562f1fbb176c67 > Cr-Commit-Position: refs/heads/master@{#419972} TBR=martiniss@chromium.org,phajdan.jr@chromium.org,recipe-roller@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=621828

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M infra/config/recipes.cfg View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
loyso (OOO)
Created Revert of Roll recipe dependencies (trivial).
4 years, 3 months ago (2016-09-21 07:15:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2352313002/1
4 years, 3 months ago (2016-09-21 07:15:39 UTC) #3
commit-bot: I haz the power
Failed to apply patch for infra/config/recipes.cfg: While running git apply --index -3 -p1; error: patch ...
4 years, 3 months ago (2016-09-21 07:16:29 UTC) #5
loyso (OOO)
4 years, 3 months ago (2016-09-21 07:21:54 UTC) #6
The fix has been landed, I believe:
https://codereview.chromium.org/2355223002

Powered by Google App Engine
This is Rietveld 408576698