Issue 23523059: Update ninja to v1.4.0 on Mac, Linux32, Linux64, Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23523059: Update ninja to v1.4.0 on Mac, Linux32, Linux64, Windows. (Closed)

Created:
7 years, 3 months ago by Nico

Modified:
7 years, 3 months ago

Reviewers:
scottmg

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools/

Visibility:
Public.

Update ninja to v1.4.0 on Mac, Linux32, Linux64, Windows. See the bug for how these were built. The linux binaries were built by thestig@chromium.org. The windows binary was built by scottmg@chromium.org. The mac binary was built by thakis@chromium.org This will hopefully fix http://crbug.com/247311 BUG=289947, 247311 r222974

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+-3 lines, --3 lines)			Patch
M	ninja	View	1 chunk	+1 line, -1 line	0 comments	Download
	ninja.exe	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
	ninja-linux32	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
	ninja-linux64	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
	ninja-mac	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Total messages: 2 (0 generated)

Nico

Bleh, apparently `gcl upload` crashing due to binary files means it won't remember the issue ...

7 years, 3 months ago (2013-09-13 00:14:06 UTC) #1

lgtm