Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 2352303002: [tools] Reduce grokdump output size (Closed)

Created:
4 years, 3 months ago by Camillo Bruni
Modified:
4 years, 3 months ago
Reviewers:
Igor Sheludko, Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[tools] Reduce grokdump output size Minidumps have gotten bigger stack ranges leading to long load times when using grokdump's web interface. A major factor seems to be the output size of the generated table. Using shorter class names and avoiding quotes for most attributes we can get a significant size reduction. BUG= Committed: https://crrev.com/031a04c6e922623d99b20907baea7249dd26f4b6 Cr-Commit-Position: refs/heads/master@{#39589}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -81 lines) Patch
M tools/grokdump.py View 24 chunks +89 lines, -81 lines 1 comment Download

Messages

Total messages: 10 (4 generated)
Camillo Bruni
PTAL
4 years, 3 months ago (2016-09-21 07:07:36 UTC) #2
Jarin
lgtm, thank you!
4 years, 3 months ago (2016-09-21 10:40:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2352303002/1
4 years, 3 months ago (2016-09-21 10:40:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 11:07:20 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/031a04c6e922623d99b20907baea7249dd26f4b6 Cr-Commit-Position: refs/heads/master@{#39589}
4 years, 3 months ago (2016-09-21 11:07:48 UTC) #8
Igor Sheludko
4 years, 3 months ago (2016-09-21 11:29:59 UTC) #10
Message was sent while issue was closed.
https://codereview.chromium.org/2352303002/diff/1/tools/grokdump.py
File tools/grokdump.py (right):

https://codereview.chromium.org/2352303002/diff/1/tools/grokdump.py#newcode2047
tools/grokdump.py:2047: <form class="navigation" action=/search.html">
DBC: I guess we are missing a " here.

Powered by Google App Engine
This is Rietveld 408576698