Replace GetForProfile by Get{FileSystem,DriveAppRegistry,DriveService)ByProfile.

Replace GetForProfile by Get{FileSystem,DriveAppRegistry,DriveService)ByProfile.

This is preparation to start returning DriveIntegrationService always from
DriveIntegrationServiceFactory::{Get,Find}ForProfile.

BUG=284972
TEST=Ran unit_tests
R=kinaba@chromium.org, satorux@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221356

[hidehiko, 2013-09-04 08:16:56]

Thank you for your review in advance,
- hidehiko

[kinaba, 2013-09-04 08:57:42]

lgtm

https://codereview.chromium.org/23523022/diff/1/chrome/browser/chromeos/drive...
File chrome/browser/chromeos/drive/file_system_util.cc (right):

https://codereview.chromium.org/23523022/diff/1/chrome/browser/chromeos/drive...
chrome/browser/chromeos/drive/file_system_util.cc:141:
DriveIntegrationServiceFactory::GetForProfile(profile);
How about implementing (as an anonymous-namespace private function)
GetIntegrationServiceByProfile and use it for the three places below? Then you
can avoid taking the same cares in three places.

https://codereview.chromium.org/23523022/diff/1/chrome/browser/chromeos/drive...
chrome/browser/chromeos/drive/file_system_util.cc:163:
DriveIntegrationServiceFactory::GetForProfile(profile);
ditto

https://codereview.chromium.org/23523022/diff/1/chrome/browser/chromeos/drive...
chrome/browser/chromeos/drive/file_system_util.cc:176:
DriveIntegrationServiceFactory::GetForProfile(profile);
ditto

[hidehiko, 2013-09-04 09:35:42]

Thank you for your quick review!

https://codereview.chromium.org/23523022/diff/1/chrome/browser/chromeos/drive...
File chrome/browser/chromeos/drive/file_system_util.cc (right):

https://codereview.chromium.org/23523022/diff/1/chrome/browser/chromeos/drive...
chrome/browser/chromeos/drive/file_system_util.cc:141:
DriveIntegrationServiceFactory::GetForProfile(profile);
On 2013/09/04 08:57:42, kinaba wrote:
> How about implementing (as an anonymous-namespace private function)
> GetIntegrationServiceByProfile and use it for the three places below? Then you
> can avoid taking the same cares in three places. 

Done.

https://codereview.chromium.org/23523022/diff/1/chrome/browser/chromeos/drive...
chrome/browser/chromeos/drive/file_system_util.cc:163:
DriveIntegrationServiceFactory::GetForProfile(profile);
On 2013/09/04 08:57:42, kinaba wrote:
> ditto

Done.

https://codereview.chromium.org/23523022/diff/1/chrome/browser/chromeos/drive...
chrome/browser/chromeos/drive/file_system_util.cc:176:
DriveIntegrationServiceFactory::GetForProfile(profile);
On 2013/09/04 08:57:42, kinaba wrote:
> ditto

Done.

[commit-bot: I haz the power, 2013-09-04 16:34:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hidehiko@chromium.org/23523022/17001

[commit-bot: I haz the power, 2013-09-04 19:31:57]

Retried try job too often on win_rel for step(s) browser_tests,
sync_integration_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-09-05 01:09:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hidehiko@chromium.org/23523022/17001

[commit-bot: I haz the power, 2013-09-05 01:09:16]

Failed to apply patch for
chrome/browser/chromeos/extensions/file_manager/file_tasks.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/chromeos/extensions/file_manager/file_tasks.cc
  Hunk #1 FAILED at 9.
  Hunk #2 succeeded at 487 (offset 1 line).
  1 out of 2 hunks FAILED -- saving rejects to file
chrome/browser/chromeos/extensions/file_manager/file_tasks.cc.rej

Patch:       chrome/browser/chromeos/extensions/file_manager/file_tasks.cc
Index: chrome/browser/chromeos/extensions/file_manager/file_tasks.cc
diff --git a/chrome/browser/chromeos/extensions/file_manager/file_tasks.cc
b/chrome/browser/chromeos/extensions/file_manager/file_tasks.cc
index
f1249fdc7545918dd0b779004db602ea21873d91..83d426a30ffd0f1b9c54447fa2c4aa0c22a78f80
100644
--- a/chrome/browser/chromeos/extensions/file_manager/file_tasks.cc
+++ b/chrome/browser/chromeos/extensions/file_manager/file_tasks.cc
@@ -9,7 +9,7 @@
 #include "base/prefs/pref_service.h"
 #include "base/strings/stringprintf.h"
 #include "chrome/browser/chromeos/drive/drive_app_registry.h"
-#include "chrome/browser/chromeos/drive/drive_integration_service.h"
+#include "chrome/browser/chromeos/drive/file_system_util.h"
 #include "chrome/browser/chromeos/drive/file_task_executor.h"
 #include
"chrome/browser/chromeos/extensions/file_manager/file_browser_handlers.h"
 #include "chrome/browser/chromeos/extensions/file_manager/fileapi_util.h"
@@ -486,15 +486,14 @@ void FindAllTypesOfTasks(
 
   // Google document are not opened by drive apps but file manager.
   if (!has_google_document) {
-    drive::DriveIntegrationService* integration_service =
-        drive::DriveIntegrationServiceFactory::GetForProfile(profile);
-    // |integration_service| is NULL if Drive is disabled.
-    if (!integration_service || !integration_service->drive_app_registry())
+    drive::DriveAppRegistry* app_registry =
+        drive::util::GetDriveAppRegistryByProfile(profile);
+    if (!app_registry) {
+      // |app_registry| is NULL if Drive is disabled.
       return;
+    }
 
-    FindDriveAppTasks(*integration_service->drive_app_registry(),
-                      path_mime_set,
-                      result_list);
+    FindDriveAppTasks(*app_registry, path_mime_set, result_list);
   }
 
   // Find and append file handler tasks. We know there aren't duplicates

[commit-bot: I haz the power, 2013-09-05 01:25:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hidehiko@chromium.org/23523022/38001

[commit-bot: I haz the power, 2013-09-05 02:34:28]

Retried try job too often on ios_dbg_simulator for step(s) ui_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[commit-bot: I haz the power, 2013-09-05 03:08:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hidehiko@chromium.org/23523022/38001

[commit-bot: I haz the power, 2013-09-05 03:26:51]

Retried try job too often on ios_dbg_simulator for step(s) ui_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[hidehiko, 2013-09-05 03:33:54]

file_tasks.cc and open_with_browser.cc are moved to c/b/chromeos/file_manager,
so I need additional OWNER approval. Could you kindly review?

[satorux1, 2013-09-05 03:39:37]

On 2013/09/05 03:33:54, hidehiko wrote:
> file_tasks.cc and open_with_browser.cc are moved to c/b/chromeos/file_manager,
> so I need additional OWNER approval. Could you kindly review?

LGTM. sorry about that. I'll add OWNERS to the new directory

[hidehiko, 2013-09-05 03:41:14]

On 2013/09/05 03:39:37, satorux1 wrote:
> On 2013/09/05 03:33:54, hidehiko wrote:
> > file_tasks.cc and open_with_browser.cc are moved to
c/b/chromeos/file_manager,
> > so I need additional OWNER approval. Could you kindly review?
> 
> LGTM. sorry about that. I'll add OWNERS to the new directory

Thank you for your quick review! Submitting...

[commit-bot: I haz the power, 2013-09-05 03:42:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hidehiko@chromium.org/23523022/69001

[commit-bot: I haz the power, 2013-09-05 04:20:52]

Retried try job too often on ios_dbg_simulator for step(s) ui_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[hidehiko, 2013-09-05 06:48:39]

Committed patchset #5 manually as r221356 (presubmit successful).