Issue 23523012: Have CustomElement::didEnterDocument() / didLeaveDocument() take a reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23523012: Have CustomElement::didEnterDocument() / didLeaveDocument() take a reference (Closed)

Created:
7 years, 3 months ago by do-not-use

Modified:
7 years, 3 months ago

Reviewers:
tkent, dominicc (has gone to gerrit), abarth-chromium

CC:
blink-reviews, webcomponents-bugzilla_chromium.org, dglazkov+blink, dominicc+watchlist_chromium.org, eae+blinkwatch, adamk+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Have CustomElement::didEnterDocument() / didLeaveDocument() take a reference Have CustomElement::didEnterDocument() / didLeaveDocument() take a Document reference instead of a pointer since it cannot be NULL. It also avoids having the call sites convert the Document reference into a pointer. BUG=281400 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157043

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -8 lines)			Patch
M	Source/core/dom/CustomElement.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/dom/CustomElement.cpp	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	Source/core/dom/Element.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

dglazkov

On 2013/08/31 18:23:24, Christophe Dumez wrote: +dominicc

7 years, 3 months ago (2013-08-31 18:45:12 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/23523012/1

7 years, 3 months ago (2013-08-31 21:00:01 UTC) #4

Message was sent while issue was closed.

Change committed as 157043

Expand Messages | Collapse Messages