Chromium Code Reviews| Index: chrome/browser/resources/md_history/side_bar.js |
| diff --git a/chrome/browser/resources/md_history/side_bar.js b/chrome/browser/resources/md_history/side_bar.js |
| index de2a3eee1419bbef7d13fa70bfb64636bf608cd8..a0a82aee324c0fb8280ad8daaa6dba28f291b7ae 100644 |
| --- a/chrome/browser/resources/md_history/side_bar.js |
| +++ b/chrome/browser/resources/md_history/side_bar.js |
| @@ -10,8 +10,6 @@ Polymer({ |
| properties: { |
| selectedPage: {type: String, notify: true}, |
| - route: Object, |
| - |
| showFooter: Boolean, |
| // If true, the sidebar is contained within an app-drawer. |
| @@ -49,8 +47,11 @@ Polymer({ |
| }, |
| /** |
| - * @param {Object} route |
| + * Prevent clicks on sidebar items from navigating. These are only links for |
| + * accessibility purposes, taps are handled separately by <iron-selector>. |
| * @private |
| */ |
| - getQueryString_: function(route) { return window.location.search; } |
|
calamity
2016/09/22 05:12:26
Without the query string, middle click goes to a d
tsergeant
2016/09/23 00:37:44
Yeah. This is a tradeoff I'm willing to make to si
|
| + onItemClick_: function(e) { |
| + e.preventDefault(); |
| + }, |
| }); |