Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2145)

Unified Diff: chrome/browser/resources/md_history/side_bar.js

Issue 2352293002: MD History: Replace app-route with a custom router (Closed)
Patch Set: Rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_history/side_bar.js
diff --git a/chrome/browser/resources/md_history/side_bar.js b/chrome/browser/resources/md_history/side_bar.js
index de2a3eee1419bbef7d13fa70bfb64636bf608cd8..a0a82aee324c0fb8280ad8daaa6dba28f291b7ae 100644
--- a/chrome/browser/resources/md_history/side_bar.js
+++ b/chrome/browser/resources/md_history/side_bar.js
@@ -10,8 +10,6 @@ Polymer({
properties: {
selectedPage: {type: String, notify: true},
- route: Object,
-
showFooter: Boolean,
// If true, the sidebar is contained within an app-drawer.
@@ -49,8 +47,11 @@ Polymer({
},
/**
- * @param {Object} route
+ * Prevent clicks on sidebar items from navigating. These are only links for
+ * accessibility purposes, taps are handled separately by <iron-selector>.
* @private
*/
- getQueryString_: function(route) { return window.location.search; }
+ onItemClick_: function(e) {
+ e.preventDefault();
+ },
});

Powered by Google App Engine
This is Rietveld 408576698