CSS Motion Path: offset-anchor and offset-position

CSS Motion Path: offset-anchor and offset-position

offset-position is the initial position of the path in the containing element.
https://drafts.fxtf.org/motion-1/#offset-position-property

The default value of offset-position is auto (the element's current position).

offset-anchor is the point in the element that is positioned along the path.
https://drafts.fxtf.org/motion-1/#offset-anchor-property

The default value of offset-anchor is center.

This patch defines the new properties, and verifies they can be parsed,
stored and read.

Not yet implemented:
- updating the 'offset' shorthand
- animation
- using the new properties when computing the motion path transforms.

Intent to Implement: https://groups.google.com/a/chromium.org/d/msg/blink-dev/uqDmsIj6zJY/cS-Vp_XG2oYJ

BUG=638055
Committed: https://crrev.com/72e3e282b889aa86071423648033f81d8bfc7b2d
Cr-Commit-Position: refs/heads/master@{#420239}

[Eric Willigers, 2016-09-21 04:01:48]

Description was changed from

==========
CSS Motion Path: offset-anchor and offset-position

offset-position is the initial position of the path in the containing element.
https://drafts.fxtf.org/motion-1/#offset-position-property

The default value of offset-position is auto (the element's current position).

offset-anchor is the point in the element that is positioned along the path.
https://drafts.fxtf.org/motion-1/#offset-anchor-property

The default value of offset-anchor is center.


This patch defines the new properties, and verifies they can be parsed,
stored and read.

Not yet implemented:
- updating the 'offset' shorthand
- animation
- using the new properties when computing the motion path transforms.

BUG=638055
==========

to

==========
CSS Motion Path: offset-anchor and offset-position

offset-position is the initial position of the path in the containing element.
https://drafts.fxtf.org/motion-1/#offset-position-property

The default value of offset-position is auto (the element's current position).

offset-anchor is the point in the element that is positioned along the path.
https://drafts.fxtf.org/motion-1/#offset-anchor-property

The default value of offset-anchor is center.


This patch defines the new properties, and verifies they can be parsed,
stored and read.

Not yet implemented:
- updating the 'offset' shorthand
- animation
- using the new properties when computing the motion path transforms.

Intent to Implement:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/uqDmsIj6zJY/cS-Vp_XG...


BUG=638055
==========

[Eric Willigers, 2016-09-21 04:04:00]

ericwilligers@chromium.org changed reviewers:
+ sashab@chromium.org

[Eric Willigers, 2016-09-21 04:04:01]

The spec for offset-anchor still needs to be updated to show the default in
center.
https://github.com/w3c/fxtf-drafts/issues/41

This was agreed yesterday by the CSS Working Group.

[sashab, 2016-09-21 05:13:53]

lgtm

[sashab, 2016-09-21 05:16:26]

sashab@chromium.org changed reviewers:
+ dstockwell@chromium.org

[sashab, 2016-09-21 05:16:27]

dstockwell@ added for owner review at eric's request.

doug - this patch is pretty straightforward, in fact this is a great patch to
look at for something like Ribbon since it encompasses everything that needs
changing to add a property.

[dstockwell, 2016-09-21 05:21:38]

lgtm

[Eric Willigers, 2016-09-21 20:43:27]

ericwilligers@chromium.org changed reviewers:
+ vollick@chromium.org

[Eric Willigers, 2016-09-21 20:43:27]

+vollick for platform OWNER

[Ian Vollick, 2016-09-21 21:22:38]

On 2016/09/21 20:43:27, Eric Willigers wrote:
> +vollick for platform OWNER

platform/ lgtm.

[Eric Willigers, 2016-09-21 22:32:18]

The CQ bit was checked by ericwilligers@chromium.org

[Eric Willigers, 2016-09-21 22:32:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
dstockwell@chromium.org, sashab@chromium.org
Link to the patchset: https://codereview.chromium.org/2352273002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-09-21 22:33:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 02:19:31]

Description was changed from

==========
CSS Motion Path: offset-anchor and offset-position

offset-position is the initial position of the path in the containing element.
https://drafts.fxtf.org/motion-1/#offset-position-property

The default value of offset-position is auto (the element's current position).

offset-anchor is the point in the element that is positioned along the path.
https://drafts.fxtf.org/motion-1/#offset-anchor-property

The default value of offset-anchor is center.


This patch defines the new properties, and verifies they can be parsed,
stored and read.

Not yet implemented:
- updating the 'offset' shorthand
- animation
- using the new properties when computing the motion path transforms.

Intent to Implement:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/uqDmsIj6zJY/cS-Vp_XG...


BUG=638055
==========

to

==========
CSS Motion Path: offset-anchor and offset-position

offset-position is the initial position of the path in the containing element.
https://drafts.fxtf.org/motion-1/#offset-position-property

The default value of offset-position is auto (the element's current position).

offset-anchor is the point in the element that is positioned along the path.
https://drafts.fxtf.org/motion-1/#offset-anchor-property

The default value of offset-anchor is center.


This patch defines the new properties, and verifies they can be parsed,
stored and read.

Not yet implemented:
- updating the 'offset' shorthand
- animation
- using the new properties when computing the motion path transforms.

Intent to Implement:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/uqDmsIj6zJY/cS-Vp_XG...


BUG=638055
==========

[commit-bot: I haz the power, 2016-09-22 02:19:32]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-22 02:21:12]

Description was changed from

==========
CSS Motion Path: offset-anchor and offset-position

offset-position is the initial position of the path in the containing element.
https://drafts.fxtf.org/motion-1/#offset-position-property

The default value of offset-position is auto (the element's current position).

offset-anchor is the point in the element that is positioned along the path.
https://drafts.fxtf.org/motion-1/#offset-anchor-property

The default value of offset-anchor is center.


This patch defines the new properties, and verifies they can be parsed,
stored and read.

Not yet implemented:
- updating the 'offset' shorthand
- animation
- using the new properties when computing the motion path transforms.

Intent to Implement:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/uqDmsIj6zJY/cS-Vp_XG...


BUG=638055
==========

to

==========
CSS Motion Path: offset-anchor and offset-position

offset-position is the initial position of the path in the containing element.
https://drafts.fxtf.org/motion-1/#offset-position-property

The default value of offset-position is auto (the element's current position).

offset-anchor is the point in the element that is positioned along the path.
https://drafts.fxtf.org/motion-1/#offset-anchor-property

The default value of offset-anchor is center.

This patch defines the new properties, and verifies they can be parsed,
stored and read.

Not yet implemented:
- updating the 'offset' shorthand
- animation
- using the new properties when computing the motion path transforms.

Intent to Implement:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/uqDmsIj6zJY/cS-Vp_XG...

BUG=638055

Committed: https://crrev.com/72e3e282b889aa86071423648033f81d8bfc7b2d
Cr-Commit-Position: refs/heads/master@{#420239}
==========

[commit-bot: I haz the power, 2016-09-22 02:21:13]

Patchset 3 (id:??) landed as
https://crrev.com/72e3e282b889aa86071423648033f81d8bfc7b2d
Cr-Commit-Position: refs/heads/master@{#420239}