Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2352263003: Revert of [inspector] provide more usefull error message for non serializable value (Closed)

Created:
4 years, 2 months ago by Michael Achenbach
Modified:
4 years, 2 months ago
Reviewers:
kozy, dgozman, alph
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [inspector] provide more usefull error message for non serializable value (patchset #3 id:40001 of https://codereview.chromium.org/2345263003/ ) Reason for revert: Breaks https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/9932 See also https://github.com/v8/v8/wiki/Blink-layout-tests Original issue's description: > [inspector] provide more usefull error message for non serializable value > > Runtime.evaluate can return result by value. We need to provide more details why method call was failed. > > BUG=chromium:645640 > R=dgozman@chromium.org,alph@chromium.org > > Committed: https://crrev.com/0965b9b5df532d3aa0583966ca60794b54f56943 > Cr-Commit-Position: refs/heads/master@{#39574} TBR=dgozman@chromium.org,alph@chromium.org,kozyatinskiy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:645640 Committed: https://crrev.com/15b4b21855c262352cb58a485b3a09efc18f064a Cr-Commit-Position: refs/heads/master@{#39580}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -45 lines) Patch
M src/inspector/InjectedScript.cpp View 3 chunks +9 lines, -14 lines 0 comments Download
M src/inspector/StringUtil.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/inspector/StringUtil.cpp View 5 chunks +9 lines, -24 lines 0 comments Download
M src/inspector/V8DebuggerAgentImpl.cpp View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of [inspector] provide more usefull error message for non serializable value
4 years, 2 months ago (2016-09-21 09:03:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2352263003/1
4 years, 2 months ago (2016-09-21 09:03:44 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-21 09:04:00 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-09-21 09:04:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/15b4b21855c262352cb58a485b3a09efc18f064a
Cr-Commit-Position: refs/heads/master@{#39580}

Powered by Google App Engine
This is Rietveld 408576698