Allow incomplete params for site engagement configs.

chrome/browser/engagement/site_engagement_score.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/engagement/site_engagement_score.h"
 
 #include <cmath>
 #include <utility>
 
 #include "base/memory/ptr_util.h"
@@ skipping 139 matching lines @@
 double SiteEngagementScore::GetMaxDecaysPerScore() {
   return GetParamValues()[MAX_DECAYS_PER_SCORE].second;
 }
 
 double SiteEngagementScore::GetLastEngagementGracePeriodInHours() {
   return GetParamValues()[LAST_ENGAGEMENT_GRACE_PERIOD_IN_HOURS].second;
 }
 
 // static
 void SiteEngagementScore::UpdateFromVariations(const char* param_name) {
-  double param_vals[MAX_VARIATION];
-
   for (int i = 0; i < MAX_VARIATION; ++i) {
+    double param;
     std::string param_string = variations::GetVariationParamValue(
         param_name, GetParamValues()[i].first);
 
     // Bail out if we didn't get a param string for the key, or if we couldn't
     // convert the param string to a double, or if we get a negative value.
     if (param_string.empty() ||
-        !base::StringToDouble(param_string, &param_vals[i]) ||
-        param_vals[i] < 0) {
-      return;
+        !base::StringToDouble(param_string, &param) ||
+        param < 0) {
+      continue;
     }
+
+    SiteEngagementScore::GetParamValues()[i].second = param;
   }
-
-  // Once we're sure everything is valid, assign the variation to the param
-  // values array.
-  for (int i = 0; i < MAX_VARIATION; ++i)
-    SiteEngagementScore::GetParamValues()[i].second = param_vals[i];
 }
 
 SiteEngagementScore::SiteEngagementScore(
     base::Clock* clock,
     const GURL& origin,
     HostContentSettingsMap* settings)
     : SiteEngagementScore(
           clock,
           origin,
           GetScoreDictForSettings(settings, origin)) {
@@ skipping 174 matching lines @@
   GetParamValues()[HIGH_ENGAGEMENT_BOUNDARY].second = 50;
   GetParamValues()[MAX_DECAYS_PER_SCORE].second = 1;
   GetParamValues()[LAST_ENGAGEMENT_GRACE_PERIOD_IN_HOURS].second = 72;
 
   // This is set to values that avoid interference with tests and are set when
   // testing these features.
   GetParamValues()[FIRST_DAILY_ENGAGEMENT].second = 0;
   GetParamValues()[DECAY_PROPORTION].second = 1;
   GetParamValues()[SCORE_CLEANUP_THRESHOLD].second = 0;
 }