Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2352253002: Added MediaSourceState unit test. (Closed)

Created:
4 years, 3 months ago by servolk
Modified:
4 years, 3 months ago
Reviewers:
chcunningham, wolenetz
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added MediaSourceState unit test. Added a new MockStreamParser and implemented several new tests for MediaSourceState using it. Also moved some test helpers around. BUG=487288 Committed: https://crrev.com/6cf8ecb7e9f375f8e0a271fea4b1a61bb3cc6d65 Cr-Commit-Position: refs/heads/master@{#420121}

Patch Set 1 #

Patch Set 2 : buildfix #

Total comments: 2

Patch Set 3 : rebase #

Patch Set 4 : nits #

Patch Set 5 : Return OnNewConfigs cb result from the AppendData helper #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+474 lines, -138 lines) Patch
M media/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/gmock_callback_support.h View 1 chunk +4 lines, -0 lines 0 comments Download
M media/base/mock_filters.h View 2 chunks +24 lines, -0 lines 0 comments Download
M media/base/mock_filters.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M media/base/null_video_sink_unittest.cc View 2 chunks +1 line, -4 lines 0 comments Download
M media/base/test_helpers.h View 2 chunks +96 lines, -0 lines 0 comments Download
M media/blink/video_frame_compositor_unittest.cc View 1 2 chunks +1 line, -4 lines 0 comments Download
M media/filters/chunk_demuxer_unittest.cc View 1 chunk +0 lines, -88 lines 0 comments Download
M media/filters/decrypting_demuxer_stream_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
A media/filters/media_source_state_unittest.cc View 1 2 3 4 1 chunk +309 lines, -0 lines 2 comments Download
M media/renderers/video_renderer_impl_unittest.cc View 32 chunks +34 lines, -38 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 31 (25 generated)
servolk
https://codereview.chromium.org/2352253002/diff/10001/media/base/test_helpers.h File media/base/test_helpers.h (right): https://codereview.chromium.org/2352253002/diff/10001/media/base/test_helpers.h#newcode150 media/base/test_helpers.h:150: MATCHER_P(HasTimestamp, timestamp_in_ms, "") { Moved from chunk_demuxer_unittest.cc https://codereview.chromium.org/2352253002/diff/10001/media/filters/chunk_demuxer_unittest.cc File ...
4 years, 3 months ago (2016-09-21 15:36:50 UTC) #16
chcunningham
Looks really good. Thanks a ton. LGTM https://codereview.chromium.org/2352253002/diff/70001/media/filters/media_source_state_unittest.cc File media/filters/media_source_state_unittest.cc (right): https://codereview.chromium.org/2352253002/diff/70001/media/filters/media_source_state_unittest.cc#newcode54 media/filters/media_source_state_unittest.cc:54: } nit: ...
4 years, 3 months ago (2016-09-21 18:23:21 UTC) #22
servolk
https://codereview.chromium.org/2352253002/diff/70001/media/filters/media_source_state_unittest.cc File media/filters/media_source_state_unittest.cc (right): https://codereview.chromium.org/2352253002/diff/70001/media/filters/media_source_state_unittest.cc#newcode54 media/filters/media_source_state_unittest.cc:54: } On 2016/09/21 18:23:21, chcunningham wrote: > nit: new ...
4 years, 3 months ago (2016-09-21 18:27:33 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2352253002/70001
4 years, 3 months ago (2016-09-21 18:36:59 UTC) #27
commit-bot: I haz the power
Committed patchset #5 (id:70001)
4 years, 3 months ago (2016-09-21 18:48:36 UTC) #29
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 18:51:29 UTC) #31
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/6cf8ecb7e9f375f8e0a271fea4b1a61bb3cc6d65
Cr-Commit-Position: refs/heads/master@{#420121}

Powered by Google App Engine
This is Rietveld 408576698