mus drag and drop: Add API to let the client cancel the drag.

mus drag and drop: Add API to let the client cancel the drag.

BUG=614037
Committed: https://crrev.com/f58400c1412b3528aff9716d632e9673a57d212f
Cr-Commit-Position: refs/heads/master@{#420205}

[Elliot Glaysher, 2016-09-20 21:39:28]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 21:40:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 22:37:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 22:37:37]

Dry run: This issue passed the CQ dry run.

[Elliot Glaysher, 2016-09-21 17:34:05]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[Elliot Glaysher, 2016-09-21 17:34:57]

erg@chromium.org changed reviewers:
+ sky@chromium.org, tsepez@chromium.org

[Elliot Glaysher, 2016-09-21 17:34:57]

sky: review
tsepez: mojom

[commit-bot: I haz the power, 2016-09-21 17:35:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-09-21 17:44:31]

lgtm

[sky, 2016-09-21 20:40:56]

LGTM

https://codereview.chromium.org/2352233002/diff/40001/services/ui/public/cpp/...
File services/ui/public/cpp/window_tree_client.cc (right):

https://codereview.chromium.org/2352233002/diff/40001/services/ui/public/cpp/...
services/ui/public/cpp/window_tree_client.cc:678:
tree_->CancelDragDrop(window->server_id());
Please add a comment that cleanup is done when server receives cancel.

https://codereview.chromium.org/2352233002/diff/40001/services/ui/ws/window_t...
File services/ui/ws/window_tree.cc (right):

https://codereview.chromium.org/2352233002/diff/40001/services/ui/ws/window_t...
services/ui/ws/window_tree.cc:1551: bool success = window &&
access_policy_->CanInitiateDragLoop(window);
I wouldn't bother with the success member. That is mostly used as a way to
inform the client of the result, but there is no callback for cancel, so no
point in the member.

Also, DVLOG the error cases please.

[Elliot Glaysher, 2016-09-21 21:01:01]

The CQ bit was checked by erg@chromium.org

[Elliot Glaysher, 2016-09-21 21:01:02]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2352233002/#ps60001
(title: "A bunch of dvlogs")

[commit-bot: I haz the power, 2016-09-21 21:01:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 23:56:17]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-22 00:31:26]

Description was changed from

==========
mus drag and drop: Add API to let the client cancel the drag.

BUG=614037
==========

to

==========
mus drag and drop: Add API to let the client cancel the drag.

BUG=614037

Committed: https://crrev.com/f58400c1412b3528aff9716d632e9673a57d212f
Cr-Commit-Position: refs/heads/master@{#420205}
==========

[commit-bot: I haz the power, 2016-09-22 00:31:27]

Patchset 4 (id:??) landed as
https://crrev.com/f58400c1412b3528aff9716d632e9673a57d212f
Cr-Commit-Position: refs/heads/master@{#420205}