Add Ctrl+Alt+H as global shortcut to toggle high contrast mode.

Add Ctrl+Alt+H as global shortcut to toggle high contrast mode.

BUG=644758
Committed: https://crrev.com/6750eab17b2f45449fab74543ff2fdbcdc122a4e
Cr-Commit-Position: refs/heads/master@{#419884}

[dmazzoni, 2016-09-20 21:31:42]

dmazzoni@chromium.org changed reviewers:
+ jamescook@chromium.org, mpearson@chromium.org

[dmazzoni, 2016-09-20 21:31:43]

jamescook: ash/
mpearson: tools/metrics/

Thanks!

[dmazzoni, 2016-09-20 21:31:47]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 21:33:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-09-20 21:37:13]

LGTM

https://codereview.chromium.org/2352213002/diff/1/ash/common/accelerators/acc...
File ash/common/accelerators/accelerator_controller.cc (right):

https://codereview.chromium.org/2352213002/diff/1/ash/common/accelerators/acc...
ash/common/accelerators/accelerator_controller.cc:469: void
HandleToggleHighContrast() {
Thanks for keeping the functions alphabetized.

https://codereview.chromium.org/2352213002/diff/1/tools/metrics/actions/actio...
File tools/metrics/actions/actions.xml (right):

https://codereview.chromium.org/2352213002/diff/1/tools/metrics/actions/actio...
tools/metrics/actions/actions.xml:894: <description>Toggles Chrome OS High
Contrast Mode</description>
nit: Maybe "Recorded when user toggles Chrome OS high contrast mode" or "User
toggled Chrome OS high contrast mode"?  And/or say something about shortcut key?

[dmazzoni, 2016-09-20 21:42:59]

https://codereview.chromium.org/2352213002/diff/1/tools/metrics/actions/actio...
File tools/metrics/actions/actions.xml (right):

https://codereview.chromium.org/2352213002/diff/1/tools/metrics/actions/actio...
tools/metrics/actions/actions.xml:894: <description>Toggles Chrome OS High
Contrast Mode</description>
On 2016/09/20 at 21:37:13, James Cook wrote:
> nit: Maybe "Recorded when user toggles Chrome OS high contrast mode" or "User
toggled Chrome OS high contrast mode"?  And/or say something about shortcut key?

Good idea, done

[Mark P, 2016-09-20 22:12:28]

actions.xml lgtm

[dmazzoni, 2016-09-20 22:33:28]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2016-09-20 22:33:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2352213002/#ps20001
(title: "Update action description")

[commit-bot: I haz the power, 2016-09-20 22:34:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 23:03:19]

Description was changed from

==========
Add Ctrl+Alt+H as global shortcut to toggle high contrast mode.

BUG=644758
==========

to

==========
Add Ctrl+Alt+H as global shortcut to toggle high contrast mode.

BUG=644758

Committed: https://crrev.com/6750eab17b2f45449fab74543ff2fdbcdc122a4e
Cr-Commit-Position: refs/heads/master@{#419884}
==========

[commit-bot: I haz the power, 2016-09-20 23:03:20]

Patchset 2 (id:??) landed as
https://crrev.com/6750eab17b2f45449fab74543ff2fdbcdc122a4e
Cr-Commit-Position: refs/heads/master@{#419884}

[suppasitaung6, 2016-10-04 17:34:03]

suppasitaung6@gmail.com changed reviewers:
+ suppasitaung6@gmail.com

[suppasitaung6, 2016-10-04 17:34:04]

https://plus.google.com/+LinkedIn/posts/X2jjT9JM3U4

[suppasitaung6, 2016-10-04 17:34:31]

lgtm

https://plus.google.com/+LinkedIn/posts/X2jjT9JM3U4

[Mark P, 2016-10-04 17:35:33]

actions.xml lgtm

[suppasitaung6, 2016-10-04 17:39:01]

https://plus.google.com/+LinkedIn/posts/X2jjT9JM3U4
เมื่อ 5 ต.ค. 2016 00:35 <mpearson@chromium.org> เขียนว่า:

> actions.xml lgtm
>
>
> https://codereview.chromium.org/2352213002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dmazzoni, 2016-10-24 21:54:26]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2448663002/ by dmazzoni@chromium.org.

The reason for reverting is: http://crbug.com/653330 This shortcut
conflicts with some web pages, and there's
no consensus on the proper fix (let web pages
override, or switch to another key)..