sdk/lib/_internal/pub/test/pubspec_test.dart - Issue 23522029: Support passing configuration data to a transformer plugin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub/test/pubspec_test.dart

Issue 23522029: Support passing configuration data to a transformer plugin. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Code review changes. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/pub/lib/src/pubspec.dart ('k') | sdk/lib/_internal/pub/test/serve/configuration_defaults_to_empty_map_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/pub/test/pubspec_test.dart

diff --git a/sdk/lib/_internal/pub/test/pubspec_test.dart b/sdk/lib/_internal/pub/test/pubspec_test.dart

index 092611d389325ba7f21e0359d650419f7db1cad0..44044619461a1523694538f4eaf3710bfd31c5e8 100644

--- a/sdk/lib/_internal/pub/test/pubspec_test.dart

+++ b/sdk/lib/_internal/pub/test/pubspec_test.dart

@@ -214,6 +214,15 @@ version: not version

expectFormatError('{author: abe, authors: ted}');

});

+ test("throws if a transformer isn't a string or map", () {

+ expectFormatError('{transformers: 12}');

+ expectFormatError('{transformers: [12]}');

+ });

+ test("throws if a transformer's configuration isn't a map", () {

+ expectFormatError('{transformers: {pkg: 12}}');

+ });

test("allows comment-only files", () {

var pubspec = new Pubspec.parse(null, '''

# No external dependencies yet