Issue 23522023: Move DrawDownloadItem() implementation to download_item_drag.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23522023: Move DrawDownloadItem() implementation to download_item_drag.cc (Closed)

Created:
7 years, 3 months ago by tfarina

Modified:
7 years, 3 months ago

Reviewers:
asanka, Elliot Glaysher

CC:
chromium-reviews, benjhayden+dwatch_chromium.org, asanka, dcheng

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Move DragDownloadItem() implementation to download_item_drag.cc BUG=None TEST=none, no functional change R=asanka@chromium.org, erg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221783

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -14 lines)			Patch
D	chrome/browser/download/drag_download_item_gtk.cc	View	1 chunk	+0 lines, -13 lines	0 comments	Download
M	chrome/browser/ui/gtk/download/download_item_drag.cc	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

asanka

lgtm, but please update the commit message to say DragDownloadItem().

7 years, 3 months ago (2013-09-06 19:49:24 UTC) #3

tfarina

7 years, 3 months ago (2013-09-06 21:16:28 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r221783 (presubmit successful).